Skip to content

Use public item_to_value property in Trace and Logging#4947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theacodes merged 1 commit into from
Feb 27, 2018
Merged

Use public item_to_value property in Trace and Logging #4947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions logging/google/cloud/logging/_gapic.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -94,7 +94,7 @@ def list_entries(self, projects, filter_='', order_by='',
# objects are created by entry_from_resource, they can be
# re-used by other log entries from the same logger.
loggers = {}
page_iter._item_to_value = functools.partial(
page_iter.item_to_value = functools.partial(
_item_to_entry, loggers=loggers)
return page_iter

Expand DownExpand Up@@ -175,7 +175,7 @@ def list_sinks(self, project, page_size=0, page_token=None):
path, page_size=page_size)
page_iter.client = self._client
page_iter.next_page_token = page_token
page_iter._item_to_value = _item_to_sink
page_iter.item_to_value = _item_to_sink
return page_iter

def sink_create(self, project, sink_name, filter_, destination,
Expand DownExpand Up@@ -327,7 +327,7 @@ def list_metrics(self, project, page_size=0, page_token=None):
path, page_size=page_size)
page_iter.client = self._client
page_iter.next_page_token = page_token
page_iter._item_to_value = _item_to_metric
page_iter.item_to_value = _item_to_metric
return page_iter

def metric_create(self, project, metric_name, filter_, description):
Expand Down
2 changes: 1 addition & 1 deletion trace/google/cloud/trace/v1/_gapic.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,7 @@ def list_traces(
end_time=end_time,
filter_=filter_,
order_by=order_by)
page_iter._item_to_value = _item_to_mapping
page_iter.item_to_value = _item_to_mapping
page_iter.next_page_token = page_token
return page_iter

Expand Down