Uh oh!
There was an error while loading. Please reload this page.
Fix broken pandas based tests - #5215
Merged
theacodes merged 2 commits intoApr 20, 2018
Merged
Conversation
supriyagargforce-pushed
the
monitoring-test
branch
from
April 20, 2018 05:43
dbd36a2 to
88ffe7aComparesupriyagarg
commented
Apr 20, 2018
ContributorAuthor
@jonparrott Looks like the 2 lines not covered are the ones that check if pandas exists, and sets it to None otherwise: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/monitoring-autogen/monitoring/google/cloud/monitoring_v3/_dataframe.py#L21 What is a reasonable way to test this? |
tseaver
commented
Apr 20, 2018
Contributor
@supriyagarg you can just add Also, the google/cloud/monitoring_v3/__init__.py:22:80: E501linetoolong (80>79characters)
google/cloud/monitoring_v3/__init__.py:44:80: E501linetoolong (90>79characters) |
supriyagargforce-pushed
the
monitoring-test
branch
from
April 20, 2018 19:08
7dd1367 to
8fe1f5aComparesupriyagargforce-pushed
the
monitoring-test
branch
from
April 20, 2018 19:09
8fe1f5a to
bc6ef58Comparesupriyagarg
commented
Apr 20, 2018
ContributorAuthor
@tseaver: thanks for your comments! |
theacodes
commented
Apr 20, 2018
Contributor
Thank you, @supriyagarg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.