Factor out mutation-setting logic from 'Connection'. by tseaver · Pull Request #524 · googleapis/google-cloud-python

tseaver · 2015-01-08T22:14:42Z

Toward #514.

coveralls · 2015-01-08T22:24:52Z

Coverage remained the same when pulling 5f28d27 on tseaver:disuse_connection_save_delete_from_batch into 7c01fcc on GoogleCloudPlatform:master.

Sign in to view

dhermes · 2015-01-08T23:27:56Z

@tseaver

This is just a part of the third bullet in Decouple Transaction from Connection #514? I.E., slowly reduce dependencies on save_entity() and delete_entities()?
ISTM delete() and put() are ready to go in datastore.api as you outlined in Push batch / transaction onto a thread-local stack inside 'with'. #518, yes? I can do that if you like or just sit back and watch.

Mostly LGTM other than small comments

Toward #514.

@dhermes

Addresses @dhermes' comments: #524 (comment)#524 (comment)#524 (comment)

tseaver · 2015-01-12T21:15:48Z

@dhermes: rebased / updated to address your concerns in 8bd5059. PTAL.

coveralls · 2015-01-12T21:16:44Z

Coverage remained the same when pulling 8bd5059 on tseaver:disuse_connection_save_delete_from_batch into 0525530 on GoogleCloudPlatform:master.

dhermes · 2015-01-12T21:20:01Z

One concern still dangling at

ifauto_id:
insert=mutation_pb.insert_auto_id.add()
auto_id_entities.append(entity)
else:
insert=mutation_pb.upsert.add()

Can you add a comment above here explaining that we don't use insert or update
but are aware of their existence and may add in future?

Can you address my two questions above? See #527 regarding point 2) above.

Addresses: #524 (comment)

tseaver · 2015-01-12T21:29:25Z

Good catch: 0525530 has the comment, which I hadn't saved to disk :(.

WRT #527: I really don't want to have begin() moved outside the context manager: it removes most of the point of the CM in the first place.

coveralls · 2015-01-12T21:29:52Z

Coverage remained the same when pulling 6af6e6d on tseaver:disuse_connection_save_delete_from_batch into 0525530 on GoogleCloudPlatform:master.

dhermes · 2015-01-12T21:33:28Z

LGTM

…om_batch Factor out mutation-setting logic from 'Connection'.

Behavior of test_batch._Connection changed in googleapis#524.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* docs: Add documentation for enums fix: Add context manager return types chore: Update gapic-generator-python to v1.8.1 PiperOrigin-RevId: 503210727 Source-Link: googleapis/googleapis@a391fd1 Source-Link: googleapis/googleapis-gen@0080f83 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…message + enable default `_` recognizer (#524) * feat: add `model` and `language_codes` fields in `RecognitionConfig` message + enable default `_` recognizer Enables specifying `model` and `language_codes` in requests without having to specify them in the Recognizer (they can still be specified in the Recognizer in the `default_recognition_config` field). Also enables using the recognizer ID `_` to perform recognition without explicitly creating a Recognizer resource. The top-level `model` and `language_codes` fields are deprecated in favor of the new fields added in the `RecognitionConfig` message. The old fields continue to work. PiperOrigin-RevId: 545698919 Source-Link: googleapis/googleapis@e73fc8f Source-Link: googleapis/googleapis-gen@b77dfdf Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjc3ZGZkZmUzOTI3ZTQwOTg3NWIyZDg5MTNmMjU3NGZhMDBhMDVhNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

….2 (#524)

Source-Link: googleapis/synthtool@453a5d9 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [rsa](https://stuvel.eu/rsa) ([source](https://togithub.com/sybrenstuvel/python-rsa)) | minor | `>=3.1.4,<4.1` -> `>=3.1.4,<4.2` | --- ### Release Notes <details> <summary>sybrenstuvel/python-rsa</summary> ### [`v4.1`](https://togithub.com/sybrenstuvel/python-rsa/blob/master/CHANGELOG.md#Version-41---released-2020-06-10) - Added support for Python 3.8. - Dropped support for Python 2 and 3.4. - Added type annotations to the source code. This will make Python-RSA easier to use in your IDE, and allows better type checking. - Added static type checking via [MyPy](http://mypy-lang.org/). - Fix [#129](https://togithub.com/sybrenstuvel/python-rsa/issues/129) Installing from source gives UnicodeDecodeError. - Switched to using [Poetry](https://poetry.eustace.io/) for package management. - Added support for SHA3 hashing: SHA3-256, SHA3-384, SHA3-512. This is natively supported by Python 3.6+ and supported via a third-party library on Python 3.5. - Choose blinding factor relatively prime to N. Thanks Christian Heimes for pointing this out. - Reject cyphertexts (when decrypting) and signatures (when verifying) that have been modified by prepending zero bytes. This resolves CVE-2020-13757. Thanks Adelapie for pointing this out. </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/google-auth-library-python).

* feat: expose reservation usage stats on jobs * Add ReservationUsage to job types in docs * Remove redundant space in docstring.

Source-Link: googleapis/synthtool@dd05f9d Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:aea14a583128771ae8aefa364e1652f3c56070168ef31beb203534222d842b8b

* tests: bump instance operation timeout to 120 seconds Toward #524. * tests: bump instance operation timeout to 240 seconds Likewise for samples instance creation.

dhermes reviewed Jan 8, 2015
View reviewed changes

Comment threadgcloud/datastore/batch.py Outdated
This comment was marked as spam.
Sign in to view

dhermes added the api: datastore Issues related to the Datastore API. label Jan 9, 2015

tseaver added 2 commits January 12, 2015 16:04

Factor out mutation-setting logic from 'Connection'.
990ab5c
Toward #514.

Clean up '_assign_entity_to_mutation'.
8bd5059
Addresses @dhermes' comments: #524 (comment)#524 (comment)#524 (comment)

Overlooked comment.
6af6e6d
Addresses: #524 (comment)

tseaver added a commit that referenced this pull request Jan 12, 2015
Merge pull request#524from tseaver/disuse_connection_save_delete_fr…
51c1069
…om_batch Factor out mutation-setting logic from 'Connection'.

tseaver merged commit 51c1069 into googleapis:masterJan 12, 2015

tseaver deleted the disuse_connection_save_delete_from_batch branch January 12, 2015 21:34

dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Jan 12, 2015
Updating api.delete() test to rely on new Batch behavior.
2908d6f
Behavior of test_batch._Connection changed in googleapis#524.

dhermes mentioned this pull request Jan 12, 2015
Adding api.delete() and removing Key.delete(). #527
Merged

parthea pushed a commit that referenced this pull request Aug 15, 2023
chore(main): release 1.22.0 (#524)
9a355f4
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
docs: fix changelog header to consistent size (#524)
59a11a1
Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(main): release 3.12.1 (#524)
24b6cef
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Aug 21, 2025
chore(deps): update dependency google-cloud-bigquery-storage to v2.16…
aa4ed74
….2 (#524)

parthea pushed a commit that referenced this pull request Sep 16, 2025
chore(deps): update dependency google-cloud-bigquery-storage to v2.16…
1401601
….2 (#524)

parthea added a commit that referenced this pull request Nov 24, 2025
docs: Update docs link in README (#524)
9ac449e

parthea pushed a commit that referenced this pull request Mar 6, 2026
feat: expose reservation usage stats on jobs (#524)
a4688e6
* feat: expose reservation usage stats on jobs * Add ReservationUsage to job types in docs * Remove redundant space in docstring.

parthea pushed a commit that referenced this pull request Mar 6, 2026
fix: permanently broken date & time unit tests on Windows (#524)
669bac4

parthea pushed a commit that referenced this pull request Mar 9, 2026
chore(deps): update dependency pyjwt to v2.10.1 (#524)
3d92328

Navigation Menu

Uh oh!

Factor out mutation-setting logic from 'Connection'. - #524

Factor out mutation-setting logic from 'Connection'.#524
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:disuse_connection_save_delete_from_batch

tseaver commented Jan 8, 2015

Uh oh!

coveralls commented Jan 8, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jan 8, 2015

Uh oh!

tseaver commented Jan 12, 2015

Uh oh!

coveralls commented Jan 12, 2015

Uh oh!

dhermes commented Jan 12, 2015

Uh oh!

tseaver commented Jan 12, 2015

Uh oh!

coveralls commented Jan 12, 2015

Uh oh!

dhermes commented Jan 12, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tseaver commented Jan 8, 2015

Uh oh!

coveralls commented Jan 8, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Jan 8, 2015

Uh oh!

tseaver commented Jan 12, 2015

Uh oh!

coveralls commented Jan 12, 2015

Uh oh!

dhermes commented Jan 12, 2015

Uh oh!

tseaver commented Jan 12, 2015

Uh oh!

coveralls commented Jan 12, 2015

Uh oh!

dhermes commented Jan 12, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants