Skip to content

Connection lookup single request - #583

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:connection-lookup-single-request
Feb 3, 2015
Merged

Connection lookup single request#583
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:connection-lookup-single-request

Conversation

@dhermes

@dhermesdhermes commented Jan 31, 2015

Copy link
Copy Markdown
Contributor

NOTE: Has #582 as a diffbase.

@tseaver This is based on my comment in the other PR. If you disagree, we can torpedo this PR. (FWIW I don't see a reason why we'd want this behavior on the Connection rather than associated with datastore.get, but maybe I'm missing something.)

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 31, 2015
@dhermesdhermes added the api: datastore Issues related to the Datastore API. label Jan 31, 2015
@coveralls

coveralls commented Jan 31, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 3b118d2 on dhermes:connection-lookup-single-request into d858ff0 on GoogleCloudPlatform:master.

@dhermes
dhermesforce-pushed the connection-lookup-single-request branch from 3b118d2 to fd833ceCompareJanuary 31, 2015 02:29
@coveralls

coveralls commented Jan 31, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling fd833ce on dhermes:connection-lookup-single-request into d858ff0 on GoogleCloudPlatform:master.

tseaver
tseaver reviewed Feb 3, 2015
View reviewed changes
Comment threadgcloud/datastore/connection.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
dhermesforce-pushed the connection-lookup-single-request branch from fd833ce to c956b3aCompareFebruary 3, 2015 17:33
@dhermesdhermes mentioned this pull request Feb 3, 2015
Merged
@dhermes
dhermesforce-pushed the connection-lookup-single-request branch from c956b3a to d517a75CompareFebruary 3, 2015 17:36
@dhermes

dhermes commented Feb 3, 2015

Copy link
Copy Markdown
ContributorAuthor

@tseaver PTAL. I rebased on top of #582 and folded the list(lookup_response.deferred) part into the original request.

@coveralls

coveralls commented Feb 3, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling d517a75 on dhermes:connection-lookup-single-request into f854cd1 on GoogleCloudPlatform:master.

@coveralls

coveralls commented Feb 3, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling d517a75 on dhermes:connection-lookup-single-request into f854cd1 on GoogleCloudPlatform:master.

@dhermesdhermes mentioned this pull request Feb 3, 2015
Closed
@tseaver

tseaver commented Feb 3, 2015

Copy link
Copy Markdown
Contributor

LGTM

@dhermes
Moving behavior in Connection.lookup to datastore.api.
e9c6260
This was so that Connection.lookup was only performing the
API call by the same name. The "lookup until all deferred return"
behavior has been moving into `datastore.get` (which is where
end users expect the behavior).
@dhermes
dhermesforce-pushed the connection-lookup-single-request branch from d517a75 to e9c6260CompareFebruary 3, 2015 21:06
@coveralls

coveralls commented Feb 3, 2015

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling e9c6260 on dhermes:connection-lookup-single-request into * on GoogleCloudPlatform:master*.

dhermes added a commit that referenced this pull request Feb 3, 2015
@dhermes
Merge pull request#583from dhermes/connection-lookup-single-request
cecdc4f
Connection lookup single request
@dhermes
dhermes merged commit cecdc4f into googleapis:masterFeb 3, 2015
@dhermes
dhermes deleted the connection-lookup-single-request branch February 3, 2015 23:38
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@renovate-bot
chore(deps): update dependency google-cloud-dialogflow to v2.16.0 (#583)
2236c7c
parthea pushed a commit that referenced this pull request Aug 21, 2025
@gcf-owl-bot
chore(deps): Update nox in .kokoro/requirements.in [autoapprove] (#583)
429e02c
Source-Link: googleapis/synthtool@92006bb
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
@gcf-owl-bot@parthea
chore(deps): Update nox in .kokoro/requirements.in [autoapprove] (#583)
e9d2064
Source-Link: googleapis/synthtool@92006bb
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 18, 2025
@aribray
feat: map "if_exists" value to LoadJobConfig.WriteDisposition (#583)
c8e13ca
* feat: map "if_exists" value to LoadJobConfig.WriteDisposition
This uses LoadJobConfig.WriteDisposition to replace if_exists='fail'/'replace'/'append' behavior in to_gbq()
### Dependency updates
- Update the minimum version of `db-dtypes` to 1.0.4
- Update the minimum version of `google-api-core` to 2.10.2
- Update the minimum version of `google-auth` to 2.13.0
- Update the minimum version of `google-auth-oauthlib` to 0.7.0
- Update the minimum version of `google-cloud-bigquery` to 3.3.5
- Update the minimum version of `google-cloud-bigquery-storage` to 2.16.2
- Update the minimum version of `pandas` to 1.1.4
- Update the minimum version of `pydata-google-auth` to 1.4.0
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore: release 0.32.3 (#583)
6818525
* chore: updated CHANGELOG.md [ci skip]
* chore: updated setup.py
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea
feat: Add attempt_direct_path argument to create_channel (#583)
ce69588
* feat: Add attempt_direct_path argument to create_channel
* add more test cases
* fix docstring
* fix docstring
* update docstring of attempt_direct_path arg
* update docstring of target arg
* Add comment for dns_prefix local variable
* Set the default value of attempt_direct_path to False
* simplify conditional statement
* use warnings.warn instead of _LOGGER.debug
* update docstring of target arg in _modify_target_for_direct_path
* s/direct_path_prefix/direct_path_separator
* default->google_auth_default
* parametrize target in def test_create_channel_implicit
* Add github issue for TODO
* filter deprecation warning related to grpcio-gcp
* format docstring
parthea pushed a commit that referenced this pull request Nov 24, 2025
@BenWhitehead
chore: replace crwilcox with googleapis/firestore-dpe as code owners (#…
3ab53e8
…583)
parthea pushed a commit that referenced this pull request Mar 2, 2026
@gcf-owl-bot
chore: removing misspelled field, add correctly spelled field (#583)
d56fd33
* fix!: removing misspelled field, add correctly spelled field
PiperOrigin-RevId: 428023165
Source-Link: googleapis/googleapis@63d374d
Source-Link: googleapis/googleapis-gen@6be9b6c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmJlOWI2YzZiNmM4NWZhY2UxOGFkYmRiZGQzZmMwNjM1NjgxMGI0YSJ9
* 🦉 Updates from OwlBot
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
@HemangChothani
fix: override django autocommit to spanner (#583)
0522b09
parthea pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot
chore(deps): update dependency google-auth to v2.38.0 (#583)
0d30bf0
parthea pushed a commit that referenced this pull request Mar 9, 2026
@danielbankhead
chore: Update CODEOWNERS for @googleapis/cloud-storage-dpe (#583)
695694c
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-storage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
Fixes #<issue_number_goes_here> 🦕
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@coveralls@tseaver@googlebot