Skip to content

Allow http as an argument to base Connection class. - #608

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:fix-551
Feb 12, 2015
Merged

Allow http as an argument to base Connection class.#608
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:fix-551

Conversation

@dhermes

@dhermesdhermes commented Feb 10, 2015

Copy link
Copy Markdown
Contributor

This will allow libraries other than httplib2 to be used.

Fixes#551.

@tseaver I dream of tearing httplib2 out as a dependency (also would need to come out of oauth2client) and using something simple like httplib for the default http object. Sigh.

But really this is to support users in specialized environments like twisted or people who prefer requests

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 10, 2015
@coveralls

coveralls commented Feb 10, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 979a334 on dhermes:fix-551 into b395360 on GoogleCloudPlatform:master.

tseaver
tseaver reviewed Feb 10, 2015
View reviewed changes
Comment threadgcloud/connection.py Outdated

This comment was marked as spam.

Sign in to view

@tseaver

tseaver commented Feb 10, 2015

Copy link
Copy Markdown
Contributor

I don't see any harm in allowing the caller to pass in the http object, but ot seems likely that there will be a significant "adapter layer" required to allow use of any other object than the httplib2 one (matching the semantics as well as the method names may be quite involve).

@dhermes

dhermes commented Feb 12, 2015

Copy link
Copy Markdown
ContributorAuthor

@tseaver I updated to non-httplib2 (folded into 2nd commit on rebase).

As for the layer, I'm unclear on who will use it but could see people building adapters that we wouldn't need to have control over.

Other issues?

@tseaver

tseaver commented Feb 12, 2015

Copy link
Copy Markdown
Contributor

LGTM

dhermes added a commit that referenced this pull request Feb 12, 2015
@dhermes
Merge pull request#608from dhermes/fix-551
06078cb
Allow http as an argument to base Connection class.
@dhermes
dhermes merged commit 06078cb into googleapis:masterFeb 12, 2015
@dhermes
dhermes deleted the fix-551 branch February 12, 2015 20:08
@dhermesdhermes mentioned this pull request Feb 14, 2015
Merged
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@release-please@parthea
chore(main): release 2.19.0 (#608)
8629b4e
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Aug 21, 2025
@gcf-owl-bot
chore: remove pinned Sphinx version [autoapprove] (#608)
b867b89
Source-Link: googleapis/synthtool@909573c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
@gcf-owl-bot@parthea
chore: remove pinned Sphinx version [autoapprove] (#608)
91f93a2
Source-Link: googleapis/synthtool@909573c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 22, 2025
@gcf-owl-bot@parthea
fix(deps): require google-api-core>=1.32.0,>=2.8.0 (#608)
befa400
feat: add audience parameter
feat: Add storage_utilization_gib_per_node to Autoscaling target
feat: Cloud Bigtable Undelete Table service and message proto files
* feat: add audience parameter
PiperOrigin-RevId: 456827138
Source-Link: googleapis/googleapis@23f1a15
Source-Link: googleapis/googleapis-gen@4075a85
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDA3NWE4NTE0ZjY3NjY5MWVjMTU2Njg4YTViYmYxODNhYTk4OTNjZSJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* feat: Add storage_utilization_gib_per_node to Autoscaling target
PiperOrigin-RevId: 457776307
Source-Link: googleapis/googleapis@982bb69
Source-Link: googleapis/googleapis-gen@0aff3eb
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGFmZjNlYmNjOGZiM2MxMGI2NzFlZTM4NmI0ZDI2MzAxMmQzZDAxMyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* feat: Cloud Bigtable Undelete Table service and message proto files
PiperOrigin-RevId: 457778403
Source-Link: googleapis/googleapis@2b0fe3b
Source-Link: googleapis/googleapis-gen@ca2a2c5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2EyYTJjNTVjYWZjYTRiODc2MzA1YjBiMTJmNzZjZTBmMTY2ZGRjYyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* chore: use gapic-generator-python 1.1.1
PiperOrigin-RevId: 459095142
Source-Link: googleapis/googleapis@4f1be99
Source-Link: googleapis/googleapis-gen@ae686d9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWU2ODZkOWNkZTRmYzNlMzZkMGFjMDJlZmI4NjQzYjE1ODkwYzFlZCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* Synchronize new proto/yaml changes.
PiperOrigin-RevId: 459539123
Source-Link: googleapis/googleapis@2e0497d
Source-Link: googleapis/googleapis-gen@d56d71b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDU2ZDcxYmVkOGY4ZDdiYzk3NzEwNTZmOGM1ZjI2NzFlN2YxMTRhMyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* fix(deps): require google-api-core>=1.32.0,>=2.8.0
* trigger ci
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore: Update gapic-generator-python to 1.25.0 (#608)
a59daac
* chore: Update gapic-generator-python to 1.24.0
PiperOrigin-RevId: 747419463
Source-Link: googleapis/googleapis@340579b
Source-Link: googleapis/googleapis-gen@e8997ec
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTg5OTdlYzUxMzZlY2I2ZWQ5YTk2OWE0YzJmMTNiM2FiNmExN2MxMiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* chore: Update gapic-generator-python to 1.24.1
PiperOrigin-RevId: 748739072
Source-Link: googleapis/googleapis@b947e52
Source-Link: googleapis/googleapis-gen@8c5821a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGM1ODIxYWE2NWE5MjFkNTliM2Y3NjUzZDZmMzdjOWM2NzQxMGMyZiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* chore: Update gapic-generator-python to 1.25.0
PiperOrigin-RevId: 755914147
Source-Link: googleapis/googleapis@97a83d7
Source-Link: googleapis/googleapis-gen@a9977ef
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTk5NzdlZmVkYzgzNmNjZWNlMWYwMWQ1MjliMDMxNWUxZWZlNTJhZCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore: add prerelease nox session (#608)
c019b9e
Source-Link: googleapis/synthtool@050953d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:65e656411895bff71cffcae97246966460160028f253c2e45b7a25d805a5b142
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@renovate-bot
chore(deps): update dependency google-cloud-logging to v3.2.2 (#608)
1e65881
parthea pushed a commit that referenced this pull request Nov 24, 2025
Chris Rossi
fix: mock call totasklets.sleepin unit test (#609)
cd8c39e
Fixes#608
parthea pushed a commit that referenced this pull request Nov 25, 2025
@renovate-bot
chore(deps): update dependency google-cloud-logging to v3.2.2 (#608)
4e59092
parthea pushed a commit that referenced this pull request Mar 2, 2026
@pradn
feat: return singleton success future for exactly-once methods in Mes…
e743810
…sage (#608)
* Return singleton success future for exactly-once methods in subscriber.Message
parthea pushed a commit that referenced this pull request Mar 6, 2026
@plamut
fix: consistent percents handling in DB API query (#619)
83174ed
Fixes#608.
Percents in the query string are now always de-escaped, regardless of whether any query parameters are passed or not.
In addition, misformatting placeholders that don't match parameter values now consistently raise `ProgrammingError`.
**PR checklist:**
- [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
parthea pushed a commit that referenced this pull request Mar 6, 2026
@vi3k6i5
fix: Remove un necessary file from code base (#608)
8e824f3
* fix: lint_setup_py was failing in Kokoro is not fixed
* fix: removing not required file
parthea pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot
chore(deps): update dependency grpc-google-iam-v1 to v0.14.1 (#608)
a39fd55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DISCUSSION: Allow http as an argument to Connection so libraries other than httplib2 can be used

4 participants

@dhermes@coveralls@tseaver@googlebot