Skip to content

Bigtable: Run instance_admin system tests on a separate instance from table_admin and data system tests. - #6579

Merged
crwilcox merged 4 commits into
googleapis:masterfrom
AVaksman:bigtable-system-flake
Mar 8, 2019
Merged

Bigtable: Run instance_admin system tests on a separate instance from table_admin and data system tests.#6579
crwilcox merged 4 commits into
googleapis:masterfrom
AVaksman:bigtable-system-flake

Conversation

@AVaksman

Copy link
Copy Markdown
Contributor

Suggestion to fix#5928
If the problem is because main instance becomes flagged as replicated after creating and deleting an additional replicated cluster in the course of instance_admin tests, than perhaps running table_admin and data tests on a separate instance would eliminate flakes

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2018
@AVaksmanAVaksman changed the title Run table_admin and data system tests on a separate instancesRun instance_admin system tests on a separate instance from table_admin and data system tests.Nov 19, 2018
@AVaksman
AVaksmanforce-pushed the bigtable-system-flake branch from 9b6c862 to e3f8eeaCompareNovember 20, 2018 05:00
@AVaksmanAVaksman changed the title Run instance_admin system tests on a separate instance from table_admin and data system tests.Bigtable: Run instance_admin system tests on a separate instance from table_admin and data system tests.Nov 20, 2018
@tseavertseaver added codegen api: bigtable Issues related to the Bigtable API. and removed codegen api: bigtable Issues related to the Bigtable API. labels Nov 21, 2018
@AVaksman
AVaksmanforce-pushed the bigtable-system-flake branch from e3f8eea to aedb905CompareDecember 2, 2018 05:31
@crwilcoxcrwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2019
@crwilcox

Copy link
Copy Markdown
Contributor

@AVaksman force running the tests. Is this an often flake that running the tests multiple times would find?

@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2019
@sduskissduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2019
@AVaksman
AVaksmanforce-pushed the bigtable-system-flake branch from aedb905 to 6010573CompareFebruary 4, 2019 04:38
@yoshi-automationyoshi-automation added the 🚨 This issue needs some love. label Feb 7, 2019
@AVaksman
AVaksmanforce-pushed the bigtable-system-flake branch from 6010573 to dea8f82CompareFebruary 12, 2019 19:24
@AVaksman

AVaksman commented Feb 12, 2019

Copy link
Copy Markdown
ContributorAuthor

@crwilcox
While running snippet tests, I have noticed that after flagging bigtable instance as replicated (create an additional cluster) even after deleting the replicated cluster methods such as table.delete and table.drop_by_prefix would fail if run right after. That issue was solved by running instance_admin and table_admin tests on separate bigtable instances.

@AVaksman

Copy link
Copy Markdown
ContributorAuthor

Unrelated lint issue is addressed in separate PR #7312. Once #7312 lands this PR will pass all the checks.

@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019
@crwilcox
crwilcox merged commit fd178d6 into googleapis:masterMar 8, 2019
parthea pushed a commit that referenced this pull request Nov 22, 2025
… table_admin and data system tests. (#6579)
* Add separate instance for table admin and data tests:
* instance_data to to type dev
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.🚨This issue needs some love.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bigtable: 'test_create_instance_w_two_clusters' flakes with '504 Deadline Exceeded'

7 participants

@AVaksman@crwilcox@sduskis@tseaver@googlebot@yoshi-automation@yoshi-kokoro