Skip to content

Moving set_default_dataset_id into _implicit_environ. - #666

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:lazy-loading-attempt-3
Feb 19, 2015
Merged

Moving set_default_dataset_id into _implicit_environ.#666
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:lazy-loading-attempt-3

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

NOTE: Has #665 as a diffbase

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2015
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 15db084 on dhermes:lazy-loading-attempt-3 into 72b6359 on GoogleCloudPlatform:master.

@dhermesdhermes added the api: datastore Issues related to the Datastore API. label Feb 19, 2015
@dhermesdhermes mentioned this pull request Feb 19, 2015
@tseaver

Copy link
Copy Markdown
Contributor

15db084 LGTM

@dhermes
dhermesforce-pushed the lazy-loading-attempt-3 branch from 15db084 to 7d75636CompareFebruary 19, 2015 19:36
@dhermes

Copy link
Copy Markdown
ContributorAuthor

Rebased on top of #665. Had to sniff out the redundant tests since the test moved wholesale.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 7d75636 on dhermes:lazy-loading-attempt-3 into 6ff634a on GoogleCloudPlatform:master.

dhermes added a commit that referenced this pull request Feb 19, 2015
Moving set_default_dataset_id into _implicit_environ.
@dhermes
dhermes merged commit 26dba83 into googleapis:masterFeb 19, 2015
@dhermes
dhermes deleted the lazy-loading-attempt-3 branch February 19, 2015 19:39
@dhermesdhermes mentioned this pull request Feb 25, 2015
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 22, 2025
* chore(deps): update all dependencies
* revert
* increase timeouts
* increase timeouts
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Features in the Ads templates require Python 3.7 or later.
parthea added a commit that referenced this pull request Nov 24, 2025
* feat: optimize _GapicCallable
* cleaned up metadata lines
* chore: avoid type checks in error wrapper
* Revert "chore: avoid type checks in error wrapper"
This reverts commit c97a6365028f3f04d20f26aa1cc0e3131164f53e.
* add default wrapped function
* fixed decorator order
* fixed spacing
* fixed comment typo
* fixed spacing
* fixed spacing
* removed unneeded helpers
* use caching
* improved metadata parsing
* improved docstring
* fixed logic
* added benchmark test
* update threshold
* run benchmark in loop for testing
* use verbose logs
* Revert testing
* used smaller value
* changed threshold
* removed link in comment
* use list type for metadata
* add types to docstring
* fixed lint
* convert to list at init time
---------
Co-authored-by: Daniel Sanche <sanche@google.com>
Co-authored-by: Daniel Sanche <d.sanche14@gmail.com>
parthea added a commit that referenced this pull request Nov 24, 2025
This reverts commit 169511959497bd4509305c5424532e817c6a9cb2.
parthea pushed a commit that referenced this pull request Nov 24, 2025
In Cloud Datastore ancestor queries are intended to be strong by default
(https://cloud.google.com/datastore/docs/concepts/structuring_for_strong_consistency) .
In Cloud Firestore in Datastore mode, all queries should be strongly
consistent by default (https://cloud.google.com/datastore/docs/upgrade-to-firestore).
Fixes#666
parthea pushed a commit that referenced this pull request Mar 2, 2026
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
parthea pushed a commit that referenced this pull request Mar 6, 2026
* feat: detect obsolete BQ Storage extra at runtime
* Cover the changes with unit tests
* Skip BQ Storage version tests if extra missing
* Rename and improve _create_bqstorage_client()
The method is renamed to _ensure_bqstorage_client() and now performs
a check if BQ Storage dependency is recent enough.
* Remove BQ Storage check from dbapi.Cursor
The check is now performed in dbapi.Connection, which is sufficient.
* Remove BQ Storage check in _pandas_helpers
The methods in higher layers already do the same check before
a BQ Storage client instance is passed to
_pandas_helpers._download_table_bqstorage() helper.
* Simplify BQ Storage client factory in magics
Lean more heavily on client._ensure_bqstorage_client() to de-duplicate
logic.
* Cover missing code lines with tests
parthea added a commit that referenced this pull request Mar 9, 2026
* ci(python): run lint / unit tests / docs as GH actions
Source-Link: googleapis/synthtool@57be0cd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6
* exclude templated github actions
* revert workflows
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@coveralls@tseaver@googlebot