Skip to content

Moving Bucket._patch_properties (and patch) to _PropertyMixin. - #690

Merged
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:storage-remove-patch-properties-blob
Mar 13, 2015
Merged

Moving Bucket._patch_properties (and patch) to _PropertyMixin.#690
dhermes merged 3 commits into
googleapis:masterfrom
dhermes:storage-remove-patch-properties-blob

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

NOTE: Has #688 as diffbase.

Also updating _PropertyBatch to call patch on __exit__.

It seems removing _patch_properties outright is a possibility

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2015
@dhermesdhermes added the api: storage Issues related to the Cloud Storage API. label Mar 9, 2015
@dhermes
dhermesforce-pushed the storage-remove-patch-properties-blob branch from a295c2f to f85f0d9CompareMarch 11, 2015 20:50
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling f85f0d9 on dhermes:storage-remove-patch-properties-blob into 83f92cc on GoogleCloudPlatform:master.

Comment threadgcloud/storage/_helpers.py Outdated

This comment was marked as spam.

This comment was marked as spam.

@tseaver

Copy link
Copy Markdown
Contributor

LGTM, module my quibble on set.update() (which you can ignore, if you disagree).

@dhermes
dhermesforce-pushed the storage-remove-patch-properties-blob branch from f85f0d9 to fcbffb5CompareMarch 13, 2015 16:43
dhermes added a commit that referenced this pull request Mar 13, 2015
…blob
Moving Bucket._patch_properties (and patch) to _PropertyMixin.
@dhermes
dhermes merged commit 1984572 into googleapis:masterMar 13, 2015
@dhermes
dhermes deleted the storage-remove-patch-properties-blob branch March 13, 2015 17:09
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling fcbffb5 on dhermes:storage-remove-patch-properties-blob into 982dd56 on GoogleCloudPlatform:master.

@dhermesdhermes mentioned this pull request Mar 13, 2015
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
Tasklets are confusing because they rely on special event-loop
behavior that was undocumented. Added a comment to work through the
example in more detail.
parthea pushed a commit that referenced this pull request Mar 9, 2026
* changes for copy backup feature
* changes to test case
* changes to documenttation
* feat: changes as per review, adding shared_backup
* changes for cross region backup
* samples: changes to list backup operations
* chore(deps): update all dependencies (#689)
* chore(deps): update dependency pytest to v7.1.1 (#690)
* feat: add support for Cross region backup proto changes (#691)
* Synchronize new proto/yaml changes.
PiperOrigin-RevId: 436114471
Source-Link: googleapis/googleapis@6379d5f
Source-Link: https://github.com/googleapis/googleapis-gen/commit/a59984b4cb711eeb186bca4f5b35adbfe60825df
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTU5OTg0YjRjYjcxMWVlYjE4NmJjYTRmNWIzNWFkYmZlNjA4MjVkZiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* feat: adding samples
* linting
Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@coveralls@tseaver@googlebot