Skip to content

Removing use of non-batchable request in storage regression. - #694

Merged
tseaver merged 1 commit into
googleapis:masterfrom
dhermes:regression-remove-batch-gets
Mar 11, 2015
Merged

Removing use of non-batchable request in storage regression.#694
tseaver merged 1 commit into
googleapis:masterfrom
dhermes:regression-remove-batch-gets

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

See my comment on #15 for context.

I was in general playing around with ditching _PropertyBatch (or just merging that functionality into Batch) and trying to figure out how to properly handle the 204 response in a patch within a batch.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2015
tseaver added a commit that referenced this pull request Mar 11, 2015
Removing use of non-batchable request in storage regression.
@tseaver
tseaver merged commit 28e42f5 into googleapis:masterMar 11, 2015
@dhermes

Copy link
Copy Markdown
ContributorAuthor

I assume you merged because it LGTY :)

@dhermes
dhermes deleted the regression-remove-batch-gets branch March 11, 2015 21:57
@tseaver

Copy link
Copy Markdown
Contributor

Yeah, one-liner, etc. -- didn't seem worth any more overhead.

@dhermesdhermes mentioned this pull request Mar 12, 2015
parthea added a commit that referenced this pull request Nov 22, 2025
Source-Link: googleapis/synthtool@25083af
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* feat: add async unsupported paramater exception
* Update google/api_core/exceptions.py
Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Victor Chudnovsky <vchudnov@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* chore: Update gapic-generator-python to v1.8.5
PiperOrigin-RevId: 511892190
Source-Link: googleapis/googleapis@a45d9c0
Source-Link: googleapis/googleapis-gen@1907294
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTkwNzI5NGIxZDgzNjVlYTI0ZjhjNWYyZTA1OWE2NDEyNGM0ZWQzYiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
* chore: release 2.2.1b3
* Updated CHANGELOG.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Vikash Singh <3116482+vi3k6i5@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
Spanner uses protos for enums. Creating a column like
Column("an_enum", Enum("A", "B", "C")) will result in a String
column. Setting supports_native_enum to False allows SQLAlchemy
to generate check constraints to enforce the enum values if the
create_constraint=True flag is passed to the Enum constructor.
Fixes: #686
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot