Skip to content

[DO NOT MERGE] AutoML: minor gapic generator changes#7224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yoshi-automation wants to merge 1 commit into from
Closed

[DO NOT MERGE] AutoML: minor gapic generator changes #7224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion automl/google/cloud/automl.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,4 +21,4 @@
from google.cloud.automl_v1beta1 import enums
from google.cloud.automl_v1beta1 import types

__all__ = ("enums", "types", "PredictionServiceClient", "AutoMlClient")
__all__ = ("enums", "types", "AutoMlClient", "PredictionServiceClient")
10 changes: 5 additions & 5 deletions automl/google/cloud/automl_v1beta1/__init__.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,14 +22,14 @@
from google.cloud.automl_v1beta1.gapic import prediction_service_client


class PredictionServiceClient(prediction_service_client.PredictionServiceClient):
__doc__ = prediction_service_client.PredictionServiceClient.__doc__
class AutoMlClient(auto_ml_client.AutoMlClient):
__doc__ = auto_ml_client.AutoMlClient.__doc__
enums = enums


class AutoMlClient(auto_ml_client.AutoMlClient):
__doc__ = auto_ml_client.AutoMlClient.__doc__
class PredictionServiceClient(prediction_service_client.PredictionServiceClient):
__doc__ = prediction_service_client.PredictionServiceClient.__doc__
enums = enums


__all__ = ("enums", "types", "PredictionServiceClient", "AutoMlClient")
__all__ = ("enums", "types", "AutoMlClient", "PredictionServiceClient")

@tseavertseaverJan 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the generator has decided to sort the wrapper classes?

3 changes: 0 additions & 3 deletions automl/google/cloud/automl_v1beta1/gapic/auto_ml_client.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,14 +33,11 @@
from google.cloud.automl_v1beta1.gapic import auto_ml_client_config
from google.cloud.automl_v1beta1.gapic import enums
from google.cloud.automl_v1beta1.gapic.transports import auto_ml_grpc_transport
from google.cloud.automl_v1beta1.proto import data_items_pb2
from google.cloud.automl_v1beta1.proto import dataset_pb2
from google.cloud.automl_v1beta1.proto import io_pb2
from google.cloud.automl_v1beta1.proto import model_evaluation_pb2
from google.cloud.automl_v1beta1.proto import model_pb2
from google.cloud.automl_v1beta1.proto import operations_pb2 as proto_operations_pb2
from google.cloud.automl_v1beta1.proto import prediction_service_pb2
from google.cloud.automl_v1beta1.proto import prediction_service_pb2_grpc

@tseavertseaverJan 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird -- if those imports weren't being used, why did our linting not fail before?

from google.cloud.automl_v1beta1.proto import service_pb2
from google.cloud.automl_v1beta1.proto import service_pb2_grpc
from google.longrunning import operations_pb2 as longrunning_operations_pb2
Expand Down
9 changes: 9 additions & 0 deletions automl/google/cloud/automl_v1beta1/gapic/prediction_service_client.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,8 +32,17 @@
prediction_service_grpc_transport,
)
from google.cloud.automl_v1beta1.proto import data_items_pb2
from google.cloud.automl_v1beta1.proto import dataset_pb2
from google.cloud.automl_v1beta1.proto import io_pb2
from google.cloud.automl_v1beta1.proto import model_evaluation_pb2
from google.cloud.automl_v1beta1.proto import model_pb2
from google.cloud.automl_v1beta1.proto import operations_pb2 as proto_operations_pb2
from google.cloud.automl_v1beta1.proto import prediction_service_pb2
from google.cloud.automl_v1beta1.proto import prediction_service_pb2_grpc
from google.cloud.automl_v1beta1.proto import service_pb2
from google.cloud.automl_v1beta1.proto import service_pb2_grpc
from google.longrunning import operations_pb2 as longrunning_operations_pb2
from google.protobuf import empty_pb2

@tseavertseaverJan 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be right -- non of these imports are used.


_GAPIC_LIBRARY_VERSION = pkg_resources.get_distribution("google-cloud-automl").version

Expand Down
10 changes: 5 additions & 5 deletions automl/synth.metadata
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
{
"updateTime": "2019-01-17T13:11:58.023570Z",
"updateTime": "2019-01-30T13:11:44.110350Z",
"sources": [
{
"generator": {
"name": "artman",
"version": "0.16.6",
"dockerImage": "googleapis/artman@sha256:12722f2ca3fbc3b53cc6aa5f0e569d7d221b46bd876a2136497089dec5e3634e"
"version": "0.16.7",
"dockerImage": "googleapis/artman@sha256:d6c8ced606eb49973ca95d2af7c55a681acc042db0f87d135968349e7bf6dd80"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "0ac60e21a1aa86c07c1836865b35308ba8178b05",
"internalRef": "229626798"
"sha": "f0195b40fd5f5f412e6819ac01df08cedb8e5fd7",
"internalRef": "231440809"
}
},
{
Expand Down