Skip to content

Container: remove unused message exports (via synth). - #7265

Closed
yoshi-automation wants to merge 1 commit into
masterfrom
autosynth-container
Closed

Container: remove unused message exports (via synth).#7265
yoshi-automation wants to merge 1 commit into
masterfrom
autosynth-container

Conversation

@yoshi-automation

Copy link
Copy Markdown
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/container/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:75bc07ef34a1de9895c18af54dc503ed3b3f3b52e85062e3360a979d2a0741e7
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/container/artman_container_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/container-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/container/v1/cluster_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/container-v1/google/cloud/container_v1/proto/cluster_service.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/container-v1/google/cloud/container_v1/proto.
synthtool > Replaced '(^.*$\\n)*' in google/cloud/container_v1/proto/cluster_service_pb2.py.
synthtool > Replaced 'nodePool>\\n' in google/cloud/container_v1/proto/cluster_service_pb2.py.
synthtool > Replaced '(\\s+)`__ instead' in google/cloud/container_v1/proto/cluster_service_pb2.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtualenv using python3.6 in /tmpfs/src/git/autosynth/working_repo/container/.nox/blacken
pip install --upgrade black
black google tests docs
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/gapic/transports/cluster_manager_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/gapic/cluster_manager_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/proto/cluster_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/gapic/cluster_manager_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/tests/unit/gapic/v1/test_cluster_manager_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/container/google/cloud/container_v1/proto/cluster_service_pb2.py
All done! ✨ 🍰 ✨
9 files reformatted, 8 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automationyoshi-automation added the api: container Issues related to the Kubernetes Engine API API. label Feb 2, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2019
@tseavertseaver changed the title [CHANGE ME] Re-generated container to pick up changes in the API or client library generator.Container: remove unused message exports (via synth).Feb 4, 2019
@crwilcoxcrwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2019
@tseaver

Copy link
Copy Markdown
Contributor

@tseaver

Copy link
Copy Markdown
Contributor

Container test failures are troubling:

unningsessionunit-2.7Creatingvirtualenvusingpython2.7in/tmpfs/src/github/google-cloud-python/container/.nox/unit-2-7pipinstall--upgrademockpytestpytest-covpipinstall--upgrade-e ../api_corepipinstall--upgrade-e ../corepipinstall--upgrade-e .
py.test--quiet--cov=google.cloud--cov=tests.unit--cov-append--cov-config=.coveragerc--cov-report=--cov-fail-under=76tests/unit
............................................................ [100%]Coverage.pywarning: Moduletests.unitwasneverimported. (module-not-imported)
Requiredtestcoverageof76%reached. Totalcoverage: 100.00%60passedin0.81secondsSessionunit-2.7wassuccessful.
Runningsessionunit-3.5Creatingvirtualenvusingpython3.5in/tmpfs/src/github/google-cloud-python/container/.nox/unit-3-5pipinstall--upgrademockpytestpytest-covpipinstall--upgrade-e ../api_corepipinstall--upgrade-e ../corepipinstall--upgrade-e .
py.test--quiet--cov=google.cloud--cov=tests.unit--cov-append--cov-config=.coveragerc--cov-report=--cov-fail-under=76tests/unit
............................................................ [100%]Coverage.pywarning: Modulegoogle.cloudwaspreviouslyimported, butnotmeasured (module-not-measured)
Coverage.pywarning: Moduletests.unitwasneverimported. (module-not-imported)
FAILRequiredtestcoverageof76%notreached. Totalcoverage: 75.56%

I cannot reproduce on my local machine, although I do see the coverage warnings during the unit test runs, and the same missing coverage lines in google/cloud/__init__.py and google/cloud/container.py.

@yoshi-automationyoshi-automation added the 🚨 This issue needs some love. label Feb 9, 2019
@tseaver

Copy link
Copy Markdown
Contributor

Unrelated test failures (shouldn't have run, karthago delenda est):

@tseaver

Copy link
Copy Markdown
Contributor

As with #7262 and #7263, the coverage-related failures here are mysterious.

@tseavertseaver added needs work This is a pull request that needs a little love. and removed 🚨 This issue needs some love. labels Feb 19, 2019
@yoshi-automationyoshi-automation added the 🚨 This issue needs some love. label May 3, 2019
@busunkim96

Copy link
Copy Markdown
Contributor

Closing this to force a regen.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: containerIssues related to the Kubernetes Engine API API.cla: yesThis human has signed the Contributor License Agreement.codegenneeds workThis is a pull request that needs a little love.🚨This issue needs some love.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@yoshi-automation@tseaver@busunkim96@crwilcox@googlebot@yoshi-kokoro