Uh oh!
There was an error while loading. Please reload this page.
WIP: fix noise from coverage. - #7413
Closed
tseaver wants to merge 3 commits into
Closed
Conversation
tseaver
commented
Mar 4, 2019
ContributorAuthor
@crwilcox I marked this one "WIP" / "do not merge" because some of these changes should happen in synth. |
tseaver
commented
May 20, 2019
ContributorAuthor
@busunkim96, @crwilcox This PR tackles the coverage-under-100% bit for fully-autogen API libraries (e.g. see #8031 today). ISTM we should be generating tests which exercise the top-level shim module. |
tseaver
commented
Jul 30, 2019
ContributorAuthor
Will be added when https://github.com/googleapis/gapic-generator/issues/2876 is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@crwilcox See #7262 for motivation.