Uh oh!
There was an error while loading. Please reload this page.
Update Natural Language service name - #7624
Merged
Merged
Conversation
tseaver
commented
Apr 1, 2019
Contributor
crwilcox
commented
Apr 1, 2019
Contributor
I am also hesitant about this. We are pretty consistent in calling this language. Though, it isn't a big deal. In the readme for language (where go from this) we refer to it as Also, should we sort this index? It is close to sorted now :) |
busunkim96
commented
Apr 1, 2019
Contributor
"Natural Language" is what the product documentation uses. https://cloud.google.com/natural-language/ |
sduskis
commented
Jul 1, 2019
Contributor
@beccasaurus, do you have any input on this change? |
beccasaurus
commented
Jul 1, 2019
Contributor
Wherever the product name is used, I would expect it to be "Natural Language" or "Natural Language API". "Language" is OK when referring to a service object / namespace / something in the client library which is named |
crwilcox
approved these changes
Jul 1, 2019
tseaver
commented
Jul 1, 2019
Contributor
mik-laj
commented
Jul 1, 2019
ContributorAuthor
@crwilcox Thanks for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
It is recommended to use the full name of the service.
Greetings,
Kamil
Reference: apache/airflow#4980 (comment)
CC: @wwlian