Skip to content

Trace: add client_info support to clients. - #7899

Merged
tseaver merged 4 commits into
googleapis:masterfrom
tseaver:7825-trace-add-client_info-support
May 8, 2019
Merged

Trace: add client_info support to clients.#7899
tseaver merged 4 commits into
googleapis:masterfrom
tseaver:7825-trace-add-client_info-support

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Toward #7825.

@tseavertseaver added the api: cloudtrace Issues related to the Cloud Trace API. label May 8, 2019
@tseaver
tseaver requested a review from tswastMay 8, 2019 17:48
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2019
@tswast

Copy link
Copy Markdown
Contributor

Linter failing (needs to be blackened).

Coverage failing

coverage report --show-missing --fail-under=100
Name Stmts Miss Branch BrPart Cover Missing
-------------------------------------------------------------------------------
google/cloud/trace/__init__.py 12 0 0 0 100%
google/cloud/trace/_gapic.py 55 0 16 0 100%
google/cloud/trace/client.py 19 0 2 0 100%
google/cloud/trace/v1/__init__.py 3 0 0 0 100%
google/cloud/trace/v1/_gapic.py 38 2 0 0 95% 164-165
google/cloud/trace/v1/client.py 32 0 12 0 100%
google/cloud/trace_v1/__init__.py 8 0 0 0 100%
google/cloud/trace_v1/types.py 19 0 8 0 100%
google/cloud/trace_v2/__init__.py 8 0 0 0 100%
google/cloud/trace_v2/types.py 23 0 8 0 100%
-------------------------------------------------------------------------------
TOTAL 217 2 46 0 99%

https://source.cloud.google.com/results/invocations/97c40a9f-2a86-4639-b98f-11a5b146a23f/targets/cloud-devrel%2Fclient-libraries%2Fgoogle-cloud-python%2Fpresubmit%2Ftrace/log

Comment threadtrace/google/cloud/trace/client.py Outdated
Comment threadtrace/tests/unit/v1/test__gapic_v1.py
@tseaver
tseaver merged commit d613b57 into googleapis:masterMay 8, 2019
@tseaver
tseaver deleted the 7825-trace-add-client_info-support branch May 8, 2019 20:33
parthea pushed a commit that referenced this pull request Oct 22, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudtraceIssues related to the Cloud Trace API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@tswast@googlebot