#744: Add 'pubsub.message.Message' class by tseaver · Pull Request #800 · googleapis/google-cloud-python

tseaver · 2015-04-06T20:51:44Z

Also, convert factory helper functions for topics and subscriptions into from_api_repr class methods.

- 'api._topic_from_resource' -> 'Topic.from_api_repr' - 'api._subscription_from_resource' -> 'Subscription.from_api_repr'

Sign in to view

dhermes · 2015-04-06T20:56:03Z

What's the necessity of a Message class? In our original document, it wasn't clear if one would ever need to exist.

tseaver · 2015-04-06T21:04:27Z

Mostly, the message has some behavior that differs from the raw mappings: base64-decoding the payload, for one. If we need to add support for timestamping / serial handling, then it gives us a place to hang it on the subscriber side.

dhermes · 2015-04-06T21:07:32Z

OK LGTM. I'm not sure I buy the savings of using None instead of {} on an object, but not worth getting hung up on.

Maps 'pubsub.v1beta2.PubsubMessage', handles base64-decode of payload. Return 'Message' instances from 'Subscription.pull()'. Update docs accordingly.

tseaver · 2015-04-06T21:30:18Z

Squashed down to 2 commits. I will merge when Travis pulls its thumb out.

coveralls · 2015-04-06T22:14:58Z

Changes Unknown when pulling 6a5f480 on tseaver:744-pubsub-message_class into * on GoogleCloudPlatform:master*.

#744: Add 'pubsub.message.Message' class

Source-Link: googleapis/synthtool@9ae0785 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:52210e0e0559f5ea8c52be148b33504022e1faef4e95fbe4b32d68022af2fa7e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-api-core](https://togithub.com/googleapis/python-api-core) | `==1.26.0` -> `==1.26.1` | [![age](https://badges.renovateapi.com/packages/pypi/google-api-core/1.26.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-api-core/1.26.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-api-core/1.26.1/compatibility-slim/1.26.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-api-core/1.26.1/confidence-slim/1.26.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/python-api-core</summary> ### [`v1.26.1`](https://togithub.com/googleapis/python-api-core/blob/master/CHANGELOG.md#1261-httpswwwgithubcomgoogleapispython-api-corecomparev1260v1261-2021-02-12) [Compare Source](https://togithub.com/googleapis/python-api-core/compare/v1.26.0...v1.26.1) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-python).

* build: use mypy<1.15.0 until #799 is fixed * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@d52e638 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4f9b3b106ad0beafc2c8a415e3f62c1a0cc23cabea115dbe841b848f581cfe99 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978

Source-Link: googleapis/synthtool@d52e638 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4f9b3b106ad0beafc2c8a415e3f62c1a0cc23cabea115dbe841b848f581cfe99 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@f58d313 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@56da63e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7

Move api factory helpers into class methods:
1052aad
- 'api._topic_from_resource' -> 'Topic.from_api_repr' - 'api._subscription_from_resource' -> 'Subscription.from_api_repr'

tseaver added the api: pubsub Issues related to the Pub/Sub API. label Apr 6, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2015

tseaver mentioned this pull request Apr 6, 2015
Initial pubsub implementation plan #744
Closed
9 tasks

dhermes reviewed Apr 6, 2015
View reviewed changes

Comment threadgcloud/pubsub/message.py
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

Add 'pubsub.message.Message' class.
6a5f480
Maps 'pubsub.v1beta2.PubsubMessage', handles base64-decode of payload. Return 'Message' instances from 'Subscription.pull()'. Update docs accordingly.

tseaver added a commit that referenced this pull request Apr 6, 2015
Merge pull request#800from tseaver/744-pubsub-message_class
9c7f1fd
#744: Add 'pubsub.message.Message' class

tseaver merged commit 9c7f1fd into googleapis:masterApr 6, 2015

tseaver deleted the 744-pubsub-message_class branch April 6, 2015 22:19

dhermes mentioned this pull request Apr 9, 2015
Upgrading version to 0.5.0. #813
Merged

parthea pushed a commit that referenced this pull request Sep 18, 2025
chore(deps): update dependency pytest to v8.3.2 (#800)
7b8462b

parthea pushed a commit that referenced this pull request Nov 26, 2025
chore: release 1.33.0 (#800)
64efd43
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Mar 6, 2026
chore(deps): update dependency google-cloud-bigquery to v2.22.1 (#800)
b1c6daf

Navigation Menu

Uh oh!

#744: Add 'pubsub.message.Message' class - #800

#744: Add 'pubsub.message.Message' class#800
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:744-pubsub-message_class

tseaver commented Apr 6, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Apr 6, 2015

Uh oh!

tseaver commented Apr 6, 2015

Uh oh!

dhermes commented Apr 6, 2015

Uh oh!

tseaver commented Apr 6, 2015

Uh oh!

coveralls commented Apr 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tseaver commented Apr 6, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Apr 6, 2015

Uh oh!

tseaver commented Apr 6, 2015

Uh oh!

dhermes commented Apr 6, 2015

Uh oh!

tseaver commented Apr 6, 2015

Uh oh!

coveralls commented Apr 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants