Skip to content

BigQuery Datatransfer: Fix coverage in 'types.py' (via synth). - #8147

Closed
yoshi-automation wants to merge 1 commit into
masterfrom
autosynth-bigquery_datatransfer
Closed

BigQuery Datatransfer: Fix coverage in 'types.py' (via synth).#8147
yoshi-automation wants to merge 1 commit into
masterfrom
autosynth-bigquery_datatransfer

Conversation

@yoshi-automation

@yoshi-automationyoshi-automation commented May 25, 2019

Copy link
Copy Markdown
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:28d4271586772b275cd3bc95cb46bd227a24d3c9048de45dccdb7f3afb0bfba9
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/bigquery/datatransfer/artman_bigquerydatatransfer.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerydatatransfer-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/bigquery/datatransfer/v1/transfer.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerydatatransfer-v1/google/cloud/bigquery_datatransfer_v1/proto/transfer.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/bigquery/datatransfer/v1/datatransfer.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerydatatransfer-v1/google/cloud/bigquery_datatransfer_v1/proto/datatransfer.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/bigquerydatatransfer-v1/google/cloud/bigquery_datatransfer_v1/proto.
synthtool > Replaced 'from google.cloud.bigquery.datatransfer_v1.proto' in google/cloud/bigquery_datatransfer_v1/proto/datatransfer_pb2.py.
synthtool > Replaced 'from google.cloud.bigquery.datatransfer_v1.proto' in google/cloud/bigquery_datatransfer_v1/proto/datatransfer_pb2_grpc.py.
synthtool > Replaced 'google-cloud-bigquerydatatransfer' in google/cloud/bigquery_datatransfer_v1/gapic/data_transfer_service_client.py.
synthtool > Replaced 'import google.api_core.gapic_v1.method\n' in google/cloud/bigquery_datatransfer_v1/gapic/data_transfer_service_client.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtualenv using python3.6 in /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/.nox/blacken
pip install black
black docs google tests noxfile.py setup.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/gapic/data_transfer_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/gapic/transports/data_transfer_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/proto/datatransfer_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/proto/transfer_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/noxfile.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/tests/system/gapic/v1/test_system_data_transfer_service_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/gapic/data_transfer_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/proto/transfer_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/tests/unit/gapic/v1/test_data_transfer_service_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/bigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/proto/datatransfer_pb2.py
All done! ✨ 🍰 ✨
16 files reformatted, 5 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation
yoshi-automation requested a review from a teamMay 25, 2019 12:14
@yoshi-automationyoshi-automation added the api: bigquerydatatransfer Issues related to the BigQuery Data Transfer Service API. label May 25, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 25, 2019
@tseavertseaver mentioned this pull request May 25, 2019
Closed
@tseavertseaver changed the title [CHANGE ME] Re-generated bigquery_datatransfer to pick up changes in the API or client library generator.BigQuery Datatransfer: Fix coverage in 'types.py' (via synth).May 25, 2019
tseaver
tseaver reviewed May 25, 2019
View reviewed changes
Comment threadbigquery_datatransfer/google/cloud/bigquery_datatransfer_v1/types.py
names = []

for module in _shared_modules:
for module in _shared_modules: # pragma: NO COVER

@tseavertseaverMay 25, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this change actually causes the unit-level coverage threshold to fail (see #8174).

tseaver
tseaver suggested changes May 25, 2019
View reviewed changes

@tseavertseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to lower the coverage level required for individual 'unit' test runs before merging here.

@tseavertseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 25, 2019
@yoshi-automationyoshi-automation added the 🚨 This issue needs some love. label Jun 4, 2019
@tswast

tswast commented Jun 6, 2019

Copy link
Copy Markdown
Contributor

I see the robot just sent out a bunch of coverage-related changes. Do we need to close this to pick those up?

Also FYI: I'm changing the synth.py file slightly in #7703 to update the noxfile to add sample code tests.

@tswasttswast mentioned this pull request Jun 6, 2019
Merged
@tseaver

tseaver commented Jun 6, 2019

Copy link
Copy Markdown
Contributor

@tswast

Do we need to close this to pick those up?

Yes, in fact this issue was the motivator for the synthtool PR I merged yesterday which triggered those jobs.

@tseavertseaver closed this Jun 6, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tseavertseavertseaver requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerydatatransferIssues related to the BigQuery Data Transfer Service API.cla: yesThis human has signed the Contributor License Agreement.codegendo not mergeIndicates a pull request not ready for merge, due to either quality or timing.🚨This issue needs some love.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoshi-automation@tswast@tseaver@googlebot