Decouple connection from Blob by dhermes · Pull Request #823 · googleapis/google-cloud-python

dhermes · 2015-04-14T18:20:26Z

NOTE: Has #822 as diffbase.

Towards #728

@tseaver I made a separate commit for each method with used Blob.connection but can combine them if you like.

I wanted to get rid of the Blob.connection property, but _PropertyMixin.reload() and _PropertyMixin.patch() use it as well as ObjectACL.reload() and ObjectACL.save().

coveralls · 2015-04-14T18:24:45Z

Coverage remained the same at 100.0% when pulling 5cf9023 on dhermes:decouple-connection-in-blob into 6283ab9 on GoogleCloudPlatform:master.

tseaver · 2015-04-15T20:12:21Z

9932f0d LGTM
e429f9a LGTM
8ebb280 see comments inline (setting connection=None in ctors to verify that override is used)
824ff20 same issue
5cf9023 same issue

dhermes · 2015-04-15T21:51:57Z

@tseaver I imagine this being a transient issue since at some point connection will not be bound to any of the types or to the stubs.

I'm not sure what would need to be checked either.

tseaver · 2015-04-16T12:55:32Z

@dhermes in the tests, we should pass None to the bucket ctor in order to ensure that the passed-in connection is being used (the tests as we have them would pass if the methods took the connection argument, but then fell back to using self.connection).

dhermes · 2015-04-16T16:29:43Z

The heisenbug that @jgeewax fixed in #834 raised it's head here too. Only the 2nd time I had seen (build failure was first). Will rebase.

@tseaver All the Blob methods I changed use the passed in connection only and don't fall back to self.connection.

They are moving towards no connection anywhere, so falling back is a no-no.

coveralls · 2015-04-16T16:40:37Z

Coverage remained the same at 100.0% when pulling ca34a4a on dhermes:decouple-connection-in-blob into 40d84e9 on GoogleCloudPlatform:master.

tseaver · 2015-04-16T16:49:34Z

That's why having the bucket initialized with an invalid connection is the Right Thing (TM): it ensures that fallback cannot cause the test to succeed.

dhermes · 2015-04-16T16:51:47Z

Gotcher. Current plan is to cherry-pick each of the 5 commits and then replace Bucket(connection) with Bucket(None) or similar. (About to spend an hour without internet on BART.)

LMK if this is a bad idea.

This is to blob and bucket can use it without import cycles.

tseaver · 2015-04-16T17:14:45Z

SGTM

Allowing the default connection to be used or direct use of a credentials object.

Allowing the default connection to be used.

Allowing the default connection to be used as fallback or takes an explicit connection argument.

dhermes · 2015-04-16T18:24:42Z

@tseaver PTAL

coveralls · 2015-04-16T18:27:02Z

Coverage remained the same at 100.0% when pulling 60d43ac on dhermes:decouple-connection-in-blob into 40d84e9 on GoogleCloudPlatform:master.

tseaver · 2015-04-16T19:10:57Z

LGTM

Decouple connection from Blob

dhermes · 2015-04-16T19:31:30Z

@tseaver Can we divvy up work and try to close out #728 together?

tseaver · 2015-04-16T20:32:37Z

How do you see the split?

dhermes · 2015-04-16T20:44:16Z

Can you handle the methods in acl.py and I'll try to cover the rest (Bucket and _PropertyMixin)?

Then we "converge" and remove the connection property from Blob (it gets used in acl.py).

tseaver · 2015-04-16T21:23:31Z

OK. I just inventoried those methods in #825.

dhermes · 2015-04-16T22:12:18Z

Awesome! Thanks

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@0da1658 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5cddfe2fb5019bbf78335bc55f15bc13e18354a56b3ff46e1834f8e540807f05 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [0.43.2](https://www.github.com/googleapis/gapic-generator-python/compare/v0.43.1...v0.43.2) (2021-03-24) ### Bug Fixes * add certain raw imports to RESERVED_NAMES ([#824](https://www.github.com/googleapis/gapic-generator-python/issues/824)) ([04bd8aa](https://www.github.com/googleapis/gapic-generator-python/commit/04bd8aaf0fc2c2c0615105cab39dc33266b66775)) * Update module alias to resolve naming conflict ([#820](https://www.github.com/googleapis/gapic-generator-python/issues/820)) ([f5e9f36](https://www.github.com/googleapis/gapic-generator-python/commit/f5e9f367ec6a72b4272f559a93f6fbb3d7e54b8b)), closes [#819](https://www.github.com/googleapis/gapic-generator-python/issues/819) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@cb96037 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

dhermes added the api: storage Issues related to the Cloud Storage API. label Apr 14, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2015

dhermes changed the title ~~Decouple connection in blob~~Decouple connection from BlobApr 14, 2015

dhermes force-pushed the decouple-connection-in-blob branch from 5cf9023 to a54b630Compare April 15, 2015 21:50

dhermes force-pushed the decouple-connection-in-blob branch from a54b630 to ca34a4aCompare April 16, 2015 16:30

Moving _require_connection from storage.api to helpers.
e5a72fd
This is to blob and bucket can use it without import cycles.

dhermes added 4 commits April 16, 2015 10:17

Removing using of Blob.connection in generate_signed_url.
e3ccb8d
Allowing the default connection to be used or direct use of a credentials object.

Removing using of Blob.connection in Blob.exists().
0421117
Allowing the default connection to be used.

Removing using of Blob.connection in all Blob.download* methods.
970beaa
Allowing the default connection to be used as fallback or takes an explicit connection argument.

Removing using of Blob.connection in all Blob.upload* methods.
60d43ac
Allowing the default connection to be used as fallback or takes an explicit connection argument.

dhermes force-pushed the decouple-connection-in-blob branch from ca34a4a to 60d43acCompare April 16, 2015 18:24

dhermes added a commit that referenced this pull request Apr 16, 2015
Merge pull request#823from dhermes/decouple-connection-in-blob
06e26ad
Decouple connection from Blob

dhermes merged commit 06e26ad into googleapis:masterApr 16, 2015

dhermes deleted the decouple-connection-in-blob branch April 16, 2015 19:31

dhermes mentioned this pull request Jun 4, 2015
Upgrading version to 0.6.0. #907
Merged

parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: Ignore Python37DeprecationWarnings from google.auth (#823)
e12c723

parthea pushed a commit that referenced this pull request Nov 25, 2025
fix: Ignore Python37DeprecationWarnings from google.auth (#823)
11de952

parthea pushed a commit that referenced this pull request Nov 26, 2025
chore: release 2.0.0b1 (#823)
2c18d91

parthea added a commit that referenced this pull request Mar 9, 2026
chore(deps): update dependency google-cloud-pubsub to v2.13.1 (#823)
e762032
Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Uh oh!

Conversation

dhermes commented Apr 14, 2015

Uh oh!

coveralls commented Apr 14, 2015

Uh oh!

tseaver commented Apr 15, 2015

Uh oh!

dhermes commented Apr 15, 2015

Uh oh!

tseaver commented Apr 16, 2015

Uh oh!

dhermes commented Apr 16, 2015

Uh oh!

coveralls commented Apr 16, 2015

Uh oh!

tseaver commented Apr 16, 2015

Uh oh!

dhermes commented Apr 16, 2015

Uh oh!

tseaver commented Apr 16, 2015

Uh oh!

dhermes commented Apr 16, 2015

Uh oh!

coveralls commented Apr 16, 2015

Uh oh!

tseaver commented Apr 16, 2015

Uh oh!

dhermes commented Apr 16, 2015

Uh oh!

tseaver commented Apr 16, 2015

Uh oh!

dhermes commented Apr 16, 2015

Uh oh!

tseaver commented Apr 16, 2015

Uh oh!

dhermes commented Apr 16, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants