Skip to content

Monitoring: Fix environment variables for VPC tests. - #8302

Merged
busunkim96 merged 6 commits into
googleapis:masterfrom
busunkim96:monitoring-update-environ
Aug 22, 2019
Merged

Monitoring: Fix environment variables for VPC tests.#8302
busunkim96 merged 6 commits into
googleapis:masterfrom
busunkim96:monitoring-update-environ

Conversation

@busunkim96

@busunkim96busunkim96 commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

Follow up to #8295.

CC @steinwaywhw

@busunkim96busunkim96 added testing api: monitoring Issues related to the Cloud Monitoring API. labels Jun 13, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2019
@busunkim96busunkim96 changed the title Fix environment variables for VPC tests.Monitoring: Fix environment variables for VPC tests.Jun 13, 2019
@steinwaywhw

steinwaywhw commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

Hi @busunkim96 sorry I miscommunicated in our last thread. Could you keep the environment variable names as is without changing them? I believe the VPC team sets "PROJECT_ID" when they run the tests.

@steinwaywhw

steinwaywhw commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

I think @bmccutchon knows better about what environment variables the VPCSC team needs.

@busunkim96

busunkim96 commented Jun 13, 2019

Copy link
Copy Markdown
ContributorAuthor

I changed it as we also use PROJECT_ID as our default system test project. I'll poke around a bit more to see what the best way to sort this out is. Thanks for the heads up!

@bmccutchon

bmccutchon commented Jun 14, 2019

Copy link
Copy Markdown
Contributor

Yes, we do set PROJECT_ID in VPCSC tests.

@yoshi-automationyoshi-automation added the 🚨 This issue needs some love. label Jun 20, 2019
@yoshi-automationyoshi-automation removed the 🚨 This issue needs some love. label Jul 3, 2019
@tseavertseaver mentioned this pull request Jul 30, 2019
Closed
@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2019
@tseaver

tseaver commented Jul 30, 2019

Copy link
Copy Markdown
Contributor

Both Container Analysis and Grafeas jobs failed with "Test Fusion Url (This url will not work until build finishes)". I have tagged Kokoro to re-run the tests.

@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 30, 2019
tseaver
tseaver reviewed Aug 7, 2019
View reviewed changes

@tseavertseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISTM that the whole TestVPCServiceControl testcase class is conditional on the environment variables being set. Would we be better off moving the pytest.mark.skipif stuff to decorate the class, rather than the individual methods?

@bmccutchon

bmccutchon commented Aug 7, 2019

Copy link
Copy Markdown
Contributor

We (VPCSC) would actually prefer it if as many of these tests as possible are not skipped on your CI so that we can more easily tell whether a failure is VPCSC-related. (If it's also failing on your CI, it's almost certainly not a VPCSC error.)

@busunkim96

busunkim96 commented Aug 7, 2019

Copy link
Copy Markdown
ContributorAuthor

@bmccutchon That sounds good. This also came up for the Asset VPC tests. I'll work on resolving the environment variable/test runs today.

@busunkim96busunkim96 self-assigned this Aug 7, 2019
@busunkim96busunkim96 reopened this Aug 7, 2019
busunkim96
busunkim96 commented Aug 7, 2019
View reviewed changes

@busunkim96busunkim96 left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmccutchon I'm still having a bit of trouble rationalizing the CI setup. Could you look over this and make sure I have the correct understanding?

PROJECT_ID - a project inside the VPCSC perimeter
GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT - a project outside the VPCSC perimeter
GOOGLE_CLOUD_TESTS_IN_VPCSC - "true" in the VPCSC testing environment

Once this is correct I'll make another PR to fix the other VPCSC tests.

Thanks!

Comment threadmonitoring/noxfile.py Outdated
Comment threadmonitoring/tests/system/test_vpcsc.py
@bmccutchon

bmccutchon commented Aug 19, 2019

Copy link
Copy Markdown
Contributor

Your understanding is correct.

@busunkim96
busunkim96 requested a review from a teamAugust 21, 2019 23:13
@busunkim96
busunkim96 requested a review from plamutAugust 22, 2019 17:06
plamut
plamut reviewed Aug 22, 2019
View reviewed changes

@plamutplamut left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resolution of my comment is good, approving that. 👍

Cannot say much about the rest, not familiar enough with it, I'll leave that to others.

@busunkim96
busunkim96 merged commit c802ba3 into googleapis:masterAug 22, 2019
HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
@busunkim96
Monitoring: Fix environment variables for VPC tests. (googleapis#8302)
02cc9d6
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@busunkim96@emar-kar
Monitoring: Fix environment variables for VPC tests. (googleapis#8302)
960ba1b
@tseavertseaver mentioned this pull request Oct 10, 2019
Merged
@busunkim96
busunkim96 deleted the monitoring-update-environ branch January 30, 2020 01:30
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
Monitoring: Fix environment variables for VPC tests. (#8302)
946b88a
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@tseavertseavertseaver left review comments
@plamutplamutplamut left review comments
@bmccutchonbmccutchonbmccutchon left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@busunkim96busunkim96

Labels

api: monitoringIssues related to the Cloud Monitoring API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@busunkim96@steinwaywhw@bmccutchon@tseaver@plamut@googlebot@yoshi-automation@yoshi-kokoro