Skip to content

Bigtable: plug systest / snippet instance leaks. - #8416

Merged
tseaver merged 6 commits into
googleapis:masterfrom
tseaver:8378-bigtable-plug-systest-snippet-instance-leaks
Jun 20, 2019
Merged

Bigtable: plug systest / snippet instance leaks.#8416
tseaver merged 6 commits into
googleapis:masterfrom
tseaver:8378-bigtable-plug-systest-snippet-instance-leaks

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

@busunkim96, @sduskis I think this would be easier to review commit-by-commit.

Closes#8378.
Closes#7003.

Makes debugging a group of leaked instances simpler.
- Add retries for 429 responses to all 'delete' requests.
- Share a single unique suffix across all snippets, to aid in diagnosing
failures of multiple cleanups in a single job.
- Move most cleanups inside the creating snippet function: leaving them
around (particularly instances) to process end can block other jobs
from running.
- Perform cleanups for tables, clusters, and app profiles.
@tseavertseaver added testing api: bigtable Issues related to the Bigtable API. labels Jun 18, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2019
@tseaver

Copy link
Copy Markdown
ContributorAuthor

This is a testing-only change, and one which should prevent PRs for other APIs from failing CI due to quota exhaustion.

@tseaver
tseaver merged commit e081c57 into googleapis:masterJun 20, 2019
@tseaver
tseaver deleted the 8378-bigtable-plug-systest-snippet-instance-leaks branch June 20, 2019 16:33
parthea pushed a commit that referenced this pull request Nov 22, 2025
- Reuse same unique suffix across all instances in a systest / snippet run.
- Increase timeouts for opeartions involving additional clusters.
- Add retries for 429 responses to all 'delete' requests in snipped cleanup.
- Move most cleanups inside the creating snippet function: leaving them
around (particularly instances) to process end can block other jobs
from running.
- Perform cleanups for tables, clusters, and app profiles.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bigtable: system tests failing with 'quota_exceeded' Bigtable: systests leaking instances

2 participants

@tseaver@googlebot