#825: Allow passing explicit connection to '_PropertyMixin.{reload,patch}'. by tseaver · Pull Request #852 · googleapis/google-cloud-python

tseaver · 2015-05-01T14:42:24Z

coveralls · 2015-05-01T14:44:41Z

Coverage remained the same at 100.0% when pulling 843a50e on tseaver:825-storage_property_mixin-allow_explicit_connection into fb59514 on GoogleCloudPlatform:master.

tseaver · 2015-05-01T20:32:59Z

@dhermes PTAL

Sign in to view

See #825.

tseaver · 2015-05-04T20:22:54Z

FWIW forcing use of _require_connection inside _PropertyMixin.{reload,patch} makes this a bigger PR: we have to chase all the tests in derived classes which don't set up the implicit default.

tseaver · 2015-05-04T20:32:08Z

I was wrong there: the test failures were due to storage.api.get_bucket, which wasn't passing through the explicit connection to bucket.reload.

tseaver · 2015-05-04T20:33:24Z

@dhermes Rebased w/ protobuf version pin fix, and changed to use _require_connection. PTAL

Use implicit default instead. Addresses: #852 (comment)

Sign in to view

dhermes · 2015-05-04T21:15:56Z

LGTM

…_explicit_connection #825: Allow passing explicit connection to '_PropertyMixin.{reload,patch}'.

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: add new v3.0.0 API skeleton (#745) * feat: improve rows filters (#751) * feat: read rows query model class (#752) * feat: implement row and cell model classes (#753) * feat: add pooled grpc transport (#748) * feat: implement read_rows (#762) * feat: implement mutate rows (#769) * feat: literal value filter (#767) * feat: row_exists and read_row (#778) * feat: read_modify_write and check_and_mutate_row (#780) * feat: sharded read rows (#766) * feat: ping and warm with metadata (#810) * feat: mutate rows batching (#770) * chore: restructure module paths (#816) * feat: improve timeout structure (#819) * fix: api errors apply to all bulk mutations * chore: reduce public api surface (#820) * feat: improve error group tracebacks on < py11 (#825) * feat: optimize read_rows (#852) * chore: add user agent suffix (#842) * feat: optimize retries (#854) * feat: add test proxy (#836) * chore(tests): add conformance tests to CI for v3 (#870) * chore(tests): turn off fast fail for conformance tets (#882) * feat: add TABLE_DEFAULTS enum for table method arguments (#880) * fix: pass None for retry in gapic calls (#881) * feat: replace internal dictionaries with protos in gapic calls (#875) * chore: optimize gapic calls (#863) * feat: expose retryable error codes to users (#879) * chore: update api_core submodule (#897) * chore: merge main into experimental_v3 (#900) * chore: pin conformance tests to v0.0.2 (#903) * fix: bulk mutation eventual success (#909) --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: remove dependency on packaging and pkg_resources * add test case * lint * update docstring * add constraint for importlib_metadata * address feedback * address feedback * remove comment * address feedback * address feedback

…p/templates/python_library/.kokoro (#852) Source-Link: googleapis/synthtool@e13b22b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:97b671488ad548ef783a452a9e1276ac10f144d5ae56d98cc4bf77ba504082b4 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Different Zlib compression levels produce different compression markers. Co-authored-by: Zhou Wang <wangzhou@google.com> Co-authored-by: Zhou Wang <wangzhou@google.com>

…p/templates/python_library/.kokoro (#852) Source-Link: googleapis/synthtool@e13b22b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:97b671488ad548ef783a452a9e1276ac10f144d5ae56d98cc4bf77ba504082b4 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: add new v3.0.0 API skeleton (#745) * feat: improve rows filters (#751) * feat: read rows query model class (#752) * feat: implement row and cell model classes (#753) * feat: add pooled grpc transport (#748) * feat: implement read_rows (#762) * feat: implement mutate rows (#769) * feat: literal value filter (#767) * feat: row_exists and read_row (#778) * feat: read_modify_write and check_and_mutate_row (#780) * feat: sharded read rows (#766) * feat: ping and warm with metadata (#810) * feat: mutate rows batching (#770) * chore: restructure module paths (#816) * feat: improve timeout structure (#819) * fix: api errors apply to all bulk mutations * chore: reduce public api surface (#820) * feat: improve error group tracebacks on < py11 (#825) * feat: optimize read_rows (#852) * chore: add user agent suffix (#842) * feat: optimize retries (#854) * feat: add test proxy (#836) * chore(tests): add conformance tests to CI for v3 (#870) * chore(tests): turn off fast fail for conformance tets (#882) * feat: add TABLE_DEFAULTS enum for table method arguments (#880) * fix: pass None for retry in gapic calls (#881) * feat: replace internal dictionaries with protos in gapic calls (#875) * chore: optimize gapic calls (#863) * feat: expose retryable error codes to users (#879) * chore: update api_core submodule (#897) * chore: merge main into experimental_v3 (#900) * chore: pin conformance tests to v0.0.2 (#903) * fix: bulk mutation eventual success (#909) --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* build(python): fix `docs` and `docfx` builds Source-Link: googleapis/synthtool@fac8444 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5ea6d0ab82c956b50962f91d94e206d3921537ae5fe1549ec5326381d8905cfa * See googleapis/synthtool#1916 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

tseaver added the api: storage Issues related to the Cloud Storage API. label May 1, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2015

tseaver mentioned this pull request May 1, 2015
Add optional 'connection' parameter for any method that hits the wire #825
Closed

dhermes reviewed May 4, 2015
View reviewed changes

Comment threadgcloud/storage/_helpers.py Outdated
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

dhermes mentioned this pull request May 4, 2015
#825: Allow passing explicit connection to ACL.{reload,save}#853
Merged

Allow passing explicit connection to '_PropertyMixin.{reload,patch}'.
d66c6db
See #825.

Remove 'storage._helpers._PropertyMixin.connection' property.
b44d368
Use implicit default instead. Addresses: #852 (comment)

dhermes reviewed May 4, 2015
View reviewed changes

Comment threadgcloud/storage/_helpers.py
This comment was marked as spam.
Sign in to view

tseaver added a commit that referenced this pull request May 4, 2015
Merge pull request#852from tseaver/825-storage_property_mixin-allow…
2cdaeb2
…_explicit_connection #825: Allow passing explicit connection to '_PropertyMixin.{reload,patch}'.

tseaver merged commit 2cdaeb2 into googleapis:masterMay 4, 2015

tseaver deleted the 825-storage_property_mixin-allow_explicit_connection branch May 4, 2015 21:24

dhermes mentioned this pull request Jun 4, 2015
Upgrading version to 0.6.0. #907
Merged

parthea pushed a commit that referenced this pull request Mar 6, 2026
chore: add api-bigquery as a samples owner (#852)
848a41a

parthea added a commit that referenced this pull request Mar 9, 2026
chore(deps): update dependency google-cloud-spanner to v3.23.0 (#852)
ff8c854
Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Navigation Menu

Uh oh!

#825: Allow passing explicit connection to '_PropertyMixin.{reload,patch}'. - #852

#825: Allow passing explicit connection to '_PropertyMixin.{reload,patch}'.#852
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:825-storage_property_mixin-allow_explicit_connection

tseaver commented May 1, 2015

Uh oh!

coveralls commented May 1, 2015

Uh oh!

tseaver commented May 1, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented May 4, 2015

Uh oh!

tseaver commented May 4, 2015

Uh oh!

tseaver commented May 4, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented May 4, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tseaver commented May 1, 2015

Uh oh!

coveralls commented May 1, 2015

Uh oh!

tseaver commented May 1, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented May 4, 2015

Uh oh!

tseaver commented May 4, 2015

Uh oh!

tseaver commented May 4, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented May 4, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants