Skip to content

#825: Allow passing explicit connection to 'Blob.make_public' - #855

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:825-storage_blob_make_public-explicit_connection
May 7, 2015
Merged

#825: Allow passing explicit connection to 'Blob.make_public'#855
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:825-storage_blob_make_public-explicit_connection

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Requires #853 as a base.

See #825.

@tseavertseaver added the api: storage Issues related to the Cloud Storage API. label May 1, 2015
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2015
@tseavertseaver changed the title #825: Allow passing explicit connetion to 'Blob.make_public'#825: Allow passing explicit connection to 'Blob.make_public'May 1, 2015
@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 02ce8e1 on tseaver:825-storage_blob_make_public-explicit_connection into * on GoogleCloudPlatform:master*.

@dhermes

Copy link
Copy Markdown
Contributor

Ping me on this when we resolve #853

@tseaver

Copy link
Copy Markdown
ContributorAuthor

Rebased against updated branch for #853. Adjusted Blob.make_public to forward connection w/o subsitution to ACL.save.

@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling d8e7d5f on tseaver:825-storage_blob_make_public-explicit_connection into * on GoogleCloudPlatform:master*.

@tseaver

Copy link
Copy Markdown
ContributorAuthor

Rebased again against updated branch for #853.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 2478c71 on tseaver:825-storage_blob_make_public-explicit_connection into 73a341c on GoogleCloudPlatform:master.

@tseaver

Copy link
Copy Markdown
ContributorAuthor

@dhermes any remaining issues?

@dhermes

Copy link
Copy Markdown
Contributor

Have yet to review this, was waiting on the diffbase to go through. Can you rebase and ping me?

@tseaver

Copy link
Copy Markdown
ContributorAuthor

@dhermes I rebased it this morning on the latest from #853.

@tseaver

Copy link
Copy Markdown
ContributorAuthor

OIC, you'd like a rebase against master.

@dhermes

Copy link
Copy Markdown
Contributor

LGTM

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling ad0557d on tseaver:825-storage_blob_make_public-explicit_connection into aafcd2a on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request May 7, 2015
…licit_connection
#825: Allow passing explicit connection to 'Blob.make_public'
@tseaver
tseaver merged commit d134452 into googleapis:masterMay 7, 2015
@tseaver
tseaver deleted the 825-storage_blob_make_public-explicit_connection branch May 7, 2015 04:31
@dhermesdhermes mentioned this pull request Jun 4, 2015
parthea pushed a commit that referenced this pull request Aug 21, 2025
* feat: Add support for opt-in debug logging
fix: Fix typing issue with gRPC metadata when key ends in -bin
chore: Update gapic-generator-python to v1.21.0
PiperOrigin-RevId: 705285820
Source-Link: googleapis/googleapis@f9b8b91
Source-Link: googleapis/googleapis-gen@ca1e0a1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2ExZTBhMWU0NzJkNmU2ZjVkZTg4M2E1Y2I1NDcyNGYxMTJjZTM0OCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
* feat: Add support for opt-in debug logging
fix: Fix typing issue with gRPC metadata when key ends in -bin
chore: Update gapic-generator-python to v1.21.0
PiperOrigin-RevId: 705285820
Source-Link: googleapis/googleapis@f9b8b91
Source-Link: googleapis/googleapis-gen@ca1e0a1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2ExZTBhMWU0NzJkNmU2ZjVkZTg4M2E1Y2I1NDcyNGYxMTJjZTM0OCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
* feat: publish CopyBackup protos to external customers
PiperOrigin-RevId: 557192020
Source-Link: googleapis/googleapis@b4c238f
Source-Link: googleapis/googleapis-gen@feccb30
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmVjY2IzMGUzMTc3ZGE4YjdiN2U2ODE0OWNhNGJiOTE0ZjhmYWYyYSJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Includes various other performance optimizations and minor whitespace fixes.
Local testing cuts down Ads generation time to ~1m (and prevents OOM) and DialogflowCX from ~10 minutes to ~5 minutes.
parthea pushed a commit that referenced this pull request Nov 24, 2025
Mostly get rid of older Py2-only code
parthea pushed a commit that referenced this pull request Nov 26, 2025
* chore: removing owlbot directives for conversion to main
* update lock file
parthea pushed a commit that referenced this pull request Mar 2, 2026
* chore: Update gapic-generator-python to v1.8.2
PiperOrigin-RevId: 504289125
Source-Link: googleapis/googleapis@38a48a4
Source-Link: googleapis/googleapis-gen@b2dc226
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
Source-Link: googleapis/synthtool@25083af
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@coveralls@dhermes@googlebot