Skip to content

Videointelligence: Add VPC SC integration tests. - #8607

Merged
busunkim96 merged 15 commits into
googleapis:masterfrom
mkudejim:master
Jul 11, 2019
Merged

Videointelligence: Add VPC SC integration tests.#8607
busunkim96 merged 15 commits into
googleapis:masterfrom
mkudejim:master

Conversation

@mkudejim

@mkudejimmkudejim commented Jul 3, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@mkudejim
mkudejim requested a review from busunkim96 as a code ownerJuly 3, 2019 18:09
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 3, 2019
@tseavertseaver changed the title Adds VPC SC integration tests for Video Intelligence APIVideointelligence: Add VPC SC integration tests.Jul 3, 2019
@tseavertseaver added api: videointelligence Issues related to the Video Intelligence API API. testing labels Jul 3, 2019
tseaver
tseaver suggested changes Jul 3, 2019
View reviewed changes
Comment thread...gle/cloud/videointelligence_v1/gapic/transports/video_intelligence_service_grpc_transport.py Outdated
Comment thread...gle/cloud/videointelligence_v1/gapic/transports/video_intelligence_service_grpc_transport.py Outdated
Comment thread...gle/cloud/videointelligence_v1/gapic/transports/video_intelligence_service_grpc_transport.py Outdated
Comment threadvideointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py
Comment threadvideointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py
Comment threadvideointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py
Comment threadvideointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py Outdated
Comment threadvideointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py Outdated
Comment threadvideointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py Outdated
Comment threadvideointelligence/google/cloud/videointelligence_v1/gapic/video_intelligence_service_client.py Outdated
@tseavertseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 3, 2019
@busunkim96

busunkim96 commented Jul 9, 2019

Copy link
Copy Markdown
Contributor

@mkudejim I think your most recent commits added changes to other APIs. Would you mind reverting those changes?

@mkudejim

mkudejim commented Jul 9, 2019

Copy link
Copy Markdown
ContributorAuthor

@mkudejim I think your most recent commits added changes to other APIs. Would you mind reverting those changes?

Which changes are you referring to? The commits that are not by me are already merged into master and were pulled in when I pulled from upstream/master.

@busunkim96busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 9, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 9, 2019
busunkim96
busunkim96 reviewed Jul 9, 2019
View reviewed changes
Comment threadvideointelligence/tests/system.py
@googlebot

googlebot commented Jul 10, 2019

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebotgooglebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 10, 2019
@tseaver

tseaver commented Jul 10, 2019

Copy link
Copy Markdown
Contributor

@mkudejim Please rebase your branch against master (rather than merging master into it).

@busunkim96busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 10, 2019
@googlebot

googlebot commented Jul 10, 2019

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@busunkim96busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@googlebot

googlebot commented Jul 10, 2019

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 10, 2019
@busunkim96busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@busunkim96busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2019
@busunkim96
busunkim96 merged commit aba3216 into googleapis:masterJul 11, 2019
@tseavertseaver mentioned this pull request Jul 12, 2019
Closed
@tseaver

tseaver commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

@mkudejim, @busunkim96 For future reference, we need to ensure that the changes made to noxfile.py are not overwritten in autogen (see #8661).

@tseavertseaver mentioned this pull request Jul 12, 2019
Merged
This was referenced Nov 6, 2019
Merged
Closed
parthea pushed a commit that referenced this pull request Sep 22, 2023
@mkudejim@busunkim96
Add VPC SC integration tests. (#8607)
6775357
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anguillanneufanguillanneufAwaiting requested review from anguillanneuf
@crwilcoxcrwilcoxAwaiting requested review from crwilcox
@frankynfrankynAwaiting requested review from frankyn
@plamutplamutAwaiting requested review from plamut
2 more reviewers
@tseavertseavertseaver requested changes
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: videointelligenceIssues related to the Video Intelligence API API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mkudejim@busunkim96@googlebot@tseaver@yoshi-kokoro