Uh oh!
There was an error while loading. Please reload this page.
Firestore: Improve cleanups for 'watch' system tests. - #8638
Merged
tseaver merged 4 commits intoJul 10, 2019
Merged
Conversation
H/t to @pchauhan-qlogic for identifying the need to unsubscribe. Supersedes #8497. Closes#6605, #7130.
tseaver
commented
Jul 10, 2019
ContributorAuthor
Testing only change to fix flaky CI failures. Merging w/o review. |
parthea pushed a commit
that referenced
this pull request
Nov 24, 2025
H/t to @pchauhan-qlogic for identifying the need to unsubscribe. Also, use unique collection IDs for 'watch' tests. Exception for 'test_watch_query_order', which requires that we use the special 'users' collection, in order to take advantage of its index. Supersedes #8497. Closes#6605, #7130.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
H/t to @pchauhan-qlogic for identifying the need to unsubscribe.
Supersedes #8497.
Closes#6605, #7130.