Skip to content

Videointelligence: Remove face detection feature from V1 client (via synth). - #8666

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:8661-videointelligence-manual_synth
Jul 12, 2019
Merged

Videointelligence: Remove face detection feature from V1 client (via synth).#8666
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:8661-videointelligence-manual_synth

Conversation

@tseaver

@tseavertseaver commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

Closes#8661.

@tseavertseaver added api: videointelligence Issues related to the Video Intelligence API API. codegen labels Jul 12, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2019
@tseavertseaver mentioned this pull request Jul 12, 2019
Closed
@busunkim96

busunkim96 commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

BigQuery Data Transfer and Video Intelligence jobs fail with error in get_target_packages_kokoro.py

Traceback (most recent call last):
File "test_utils/scripts/get_target_packages_kokoro.py", line 98, in <module>
main()
File "test_utils/scripts/get_target_packages_kokoro.py", line 85, in main
changed_files = list(get_changed_files_from_pr(environment.pr))
File "test_utils/scripts/get_target_packages_kokoro.py", line 60, in get_changed_files_from_pr
yield info['filename']
TypeError: string indices must be integers

@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2019
@tseaver

tseaver commented Jul 12, 2019

Copy link
Copy Markdown
ContributorAuthor

@busunkim96

BigQuery Data Transfer and Video Intelligence jobs fail with error in get_target_packages_kokoro.py

Weird, the Github API is supposed to return a list of dicts as the response to that request.

I've tagged it to re-run the jobs.

@tseaver

tseaver commented Jul 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Unrelated Security Scanner failure reported as #8668 (same issue w/ get_target_packages_kokoro).

Maybe there is some Github rate limiting happening?

@tseaver
tseaver merged commit a0e077c into googleapis:masterJul 12, 2019
@tseaver
tseaver deleted the 8661-videointelligence-manual_synth branch July 12, 2019 20:06
busunkim96 added a commit that referenced this pull request Jul 12, 2019
@busunkim96
Revert "Remove face detection feature from V1 client (via synth). (#8666
ffd4a72
)"
This reverts commit a0e077c.
@busunkim96busunkim96 mentioned this pull request Jul 12, 2019
Merged
busunkim96 added a commit that referenced this pull request Jul 15, 2019
@busunkim96
Revert "Videointelligence: Remove face detection feature from V1 clie…
1f8f31d
…nt (via synth)." (#8669)
* Revert "Remove face detection feature from V1 client (via synth). (#8666)"
This reverts commit a0e077c.
* Exclude noxfile in copy.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Remove face detection feature from V1 client (via synth). (#8666)
0fbacc3
Closes#8661.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
Revert "Videointelligence: Remove face detection feature from V1 clie…
e45170e
…nt (via synth)." (#8669)
* Revert "Remove face detection feature from V1 client (via synth). (#8666)"
This reverts commit a6aa47ac76df9c6c640e055c0b1317d171ab5939.
* Exclude noxfile in copy.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcoxcrwilcoxAwaiting requested review from crwilcox
1 more reviewer
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: videointelligenceIssues related to the Video Intelligence API API.cla: yesThis human has signed the Contributor License Agreement.codegen

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@busunkim96@googlebot@yoshi-kokoro