Uh oh!
There was an error while loading. Please reload this page.
Firestore: Update conformance tests to match new repo / format. - #8689
Merged
tseaver merged 4 commits intoJul 17, 2019
Conversation
- Use new 'conformance_tests' repo. - Handle updated file hierarchy, etc.
- Copy in JSON testcase files from 'conformance-tests' repo. - Except 'update-nested-transform-and-nested-value.json', which is the reproducer case for issue #7215.
tseaver
commented
Jul 17, 2019
ContributorAuthor
Error Reporting and Text-to-Speech jobs both fail due to Kokoro-internal glitch: "Cannot check out non-mergeable pull request as if merged." |
tseaver
commented
Jul 17, 2019
ContributorAuthor
Testing only. I need this merged to start work on #7215 (the reproducer conformance test is new-style JSON only). Merging without review. |
parthea pushed a commit
that referenced
this pull request
Nov 24, 2025
Update Makefile test proto builder: - Use new 'conformance_tests' repo. - Handle updated file hierarchy, etc. Use new JSON format in 'test_cross_language.py'. - Copy in JSON testcase files from 'conformance-tests' repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies to reviewers for the size of the PR. The only "interesting" changes are in these two files:
Makefile_v1: used to generate the file we use to parse testcases.test_cross_language.py: test driver which uses the canonical testcase data files.The rest are either the
protoc-generated file for the newTestFilemessage format, or the individual testcase datafiles themselves, in their new JSON formats (with the old.textproto/.binprotofiles removed).I specifically avoided copying in the new testcase file,
update-nested-transform-and-nested-value.json,because it is the reproducer for the not-yet-fixed bug, #7215.