feat(api core): simplify from_rfc3339 methods by emar-kar · Pull Request #8742 · googleapis/google-cloud-python

emar-kar · 2019-07-24T13:22:40Z

Combining methods from_rfc3339 and from_rfc3339_nanos as requested in #7676.
from_rfc3339_nanos method marked as deprecated and refers to the new implementation.

Closes: #7676.

tseaver

In addition to deprecation (for benefit of hypothetical external clients), this PR needs remove all use of the _nanos version in our codebase (we don't want to be emitting deprecation warnings ourselves).

tseaver

Please fix the coverage and lint failures.

…leapis#9197)

…). (googleapis#9198)

…eapis#9189) * Add support for array params to Cursor.execute() * Raise NotImplementedError for STRUCT-like values

…is#9204)

crwilcox · 2019-11-07T21:47:55Z

+ regular expression.
+ """
+ # Raise deprecation warnings for things we want to go away.
+ warnings.warn(


Let's remove this warning then I am good

Two similar methods combined into one.

Re-write tests for the 'from_rfc3339_nanos' method.

Fix for coverage and lint failures.

restore previous version with testing regex first + cosmetic chgs for the descriptions

added test to check the deprecation warning

adjusted the condition for the 'from_rfc3339' method + warning fix

* deleted extra spaces

* 'if-else' statement restored to throw an exception * wrote additional tests to cover the exception

…-cloud-python into Methods-Combining

googlebot · 2019-11-08T08:18:04Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2019-11-08T08:18:28Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2019

emar-kar marked this pull request as ready for review July 24, 2019 13:34

emar-kar requested a review from busunkim96 as a code owner July 24, 2019 13:34

tseaver added api: core kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 24, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2019

tseaver suggested changes Jul 24, 2019
View reviewed changes

AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2019

tseaver suggested changes Jul 25, 2019
View reviewed changes

Comment threadapi_core/google/api_core/datetime_helpers.py
Comment threadapi_core/tests/unit/test_datetime_helpers.py
Comment threadapi_core/google/api_core/datetime_helpers.py
Comment threadapi_core/google/api_core/datetime_helpers.py Outdated

tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2019

tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2019

crwilcox self-requested a review August 22, 2019 16:10

crwilcox suggested changes Aug 22, 2019
View reviewed changes

Comment threadapi_core/google/api_core/datetime_helpers.py Outdated

busunkim96 approved these changes Aug 22, 2019
View reviewed changes

IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 23, 2019

IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2019

yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 28, 2019

crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 6, 2019

yoshi-automationand others added 5 commits September 10, 2019 13:57

Update docstrings, change timeout and retry config (via synth). (goog…
ef86976
…leapis#9197)

Make threat_types a required argument to search_hashes (via synth…
ab07845
…). (googleapis#9198)

Fix doc link (googleapis#9200)
9e1b896

BigQuery: Add support for array parameters to Cursor.execute() (googl…
adfc6d3
…eapis#9189) * Add support for array params to Cursor.execute() * Raise NotImplementedError for STRUCT-like values

Fix tests b0rken by 'google-resumable-media 0.4.0' release. (googleap…
e9f27b3
…is#9204)

crwilcox reviewed Nov 7, 2019
View reviewed changes

busunkim96and others added 10 commits November 7, 2019 13:58

feat(documentai): initial generation of documentai (googleapis#9623)
5137c03

API Core: simplify methods
873a60d
Two similar methods combined into one.

Update test_datetime_helpers.py
796204c
Re-write tests for the 'from_rfc3339_nanos' method.

Update datetime_helpers.py
0503e92
Fix for coverage and lint failures.

Update datetime_helpers.py
dc4f896
restore previous version with testing regex first + cosmetic chgs for the descriptions

Update test_datetime_helpers.py
4bcf651
added test to check the deprecation warning

Update datetime_helpers.py
8151cae
adjusted the condition for the 'from_rfc3339' method + warning fix

Update datetime_helpers.py
447ed3e
* deleted extra spaces

update datetime_helpers
1fc8661
* 'if-else' statement restored to throw an exception * wrote additional tests to cover the exception

Merge branch 'Methods-Combining' ofhttps://github.com/q-logic/google…
93f8883
…-cloud-python into Methods-Combining

emar-kar requested review from anguillanneuf, frankyn, plamut, pradn and tswast as code owners November 8, 2019 08:15

emar-kar requested a review from a teamNovember 8, 2019 08:15

update comments
9dcffee

emar-kar removed request for a team, anguillanneuf, frankyn, plamut, pradn and tswast November 8, 2019 08:16

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 8, 2019

emar-kar closed this Nov 8, 2019

emar-kar mentioned this pull request Nov 8, 2019
feat(api core): simplify from_rfc3339 methods #9641
Merged

Navigation Menu

Uh oh!

feat(api core): simplify from_rfc3339 methods - #8742

feat(api core): simplify from_rfc3339 methods#8742
emar-kar wants to merge 269 commits into
googleapis:masterfrom
MaxxleLLC:Methods-Combining

emar-kar commented Jul 24, 2019•
edited
Loading

Uh oh!

tseaver left a comment

Uh oh!

tseaver left a comment •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crwilcoxNov 7, 2019

Uh oh!

googlebot commented Nov 8, 2019

Uh oh!

googlebot commented Nov 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

emar-kar commented Jul 24, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tseaver left a comment

Choose a reason for hiding this comment

Uh oh!

tseaver left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

crwilcoxNov 7, 2019

Choose a reason for hiding this comment

Uh oh!

googlebot commented Nov 8, 2019

Uh oh!

googlebot commented Nov 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

emar-kar commented Jul 24, 2019•
edited
Loading

tseaver left a comment •
edited
Loading