Uh oh!
There was an error while loading. Please reload this page.
BigQuery: Add client_options to constructors for manual clients. - #8999
Merged
busunkim96 merged 6 commits intoAug 27, 2019
Merged
Conversation
Changing the description of the class.
client_options to constructors for manual clients.IlyaFaer
marked this pull request as ready for review
August 9, 2019 09:48
tseaver
approved these changes
Aug 9, 2019
tswast
requested changes
Aug 14, 2019
| project=self.PROJECT, | ||
| credentials=creds, | ||
| _http=http, | ||
| client_options={"api_endpoint": Connection.DEFAULT_API_ENDPOINT}, |
Contributor
There was a problem hiding this comment.
Because this test is for default Client constructor arguments, let's omit client_options from this test, but still check that API_BASE_URL has the expected value.
Contributor
There was a problem hiding this comment.
I see that we need a different test where we set client_options as a dictionary. Let's add such a test and set a value for api_endpoint to something other than the default value.
| creds = _make_credentials() | ||
| http = object() | ||
| client_options = ClientOptions(Connection.DEFAULT_API_ENDPOINT) |
Contributor
There was a problem hiding this comment.
Please check with an alternative value for the api_endpoint, since we are trying to test for non-default values in this test.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
* added new test to check 'client_options' as a dict * deleted extra asserts * chged object at 'test_ctor_w_client_options_object' to an alternative value
* fixed lint issues
19 tasks
tswast
reviewed
Aug 16, 2019
tswast
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating the tests, just one question.
Uh oh!
There was an error while loading. Please reload this page.
busunkim96
approved these changes
Aug 23, 2019
tswast
approved these changes
Aug 27, 2019
HemangChothani pushed a commit
to HemangChothani/google-cloud-python
that referenced
this pull request
Aug 29, 2019
emar-kar added a commit
to MaxxleLLC/google-cloud-python
that referenced
this pull request
Sep 18, 2019
This was referenced Sep 24, 2019
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #8475