Skip to content

Raise with extra or missing columns in load_table_from_dataframe schema. - #9096

Merged
plamut merged 1 commit into
googleapis:masterfrom
tswast:issue8140-schema-mismatch
Aug 26, 2019
Merged

Raise with extra or missing columns in load_table_from_dataframe schema.#9096
plamut merged 1 commit into
googleapis:masterfrom
tswast:issue8140-schema-mismatch

Conversation

@tswast

Copy link
Copy Markdown
Contributor

I found it to be difficult to debug typos in column/index names in the
schema, so I have hardened the error messages to indicate when unknown
field values are found.

Split from #9084
Follow-up to #8140

…hema.
I found it to be difficult to debug typos in column/index names in the
schema, so I have hardened the error messages to indicate when unknown
field values are found.
@tswasttswast added the api: bigquery Issues related to the BigQuery API. label Aug 24, 2019
@tswast
tswast requested review from a team and plamutAugust 24, 2019 00:15
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2019

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it's just the snippets tests failing. Will try to re-run them.

Edit: It was apparently flakiness, as changes in this PR are quite benign.

@plamutplamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2019
@plamut
plamut merged commit cdb4cc4 into googleapis:masterAug 26, 2019
@tswast
tswast deleted the issue8140-schema-mismatch branch August 26, 2019 17:50
@tswast

Copy link
Copy Markdown
ContributorAuthor

Thanks Peter. Next time we get a flake, let's file an issue. Seems like we've been having more test flakes lately.

HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
…hema. (googleapis#9096)
I found it to be difficult to debug typos in column/index names in the
schema, so I have hardened the error messages to indicate when unknown
field values are found.
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
…hema. (googleapis#9096)
I found it to be difficult to debug typos in column/index names in the
schema, so I have hardened the error messages to indicate when unknown
field values are found.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tswast@plamut@googlebot@yoshi-kokoro