Skip to content

Storage: Make 'Blob.bucket' a readonly property. - #9113

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:9107-storage-blob-bucket-readonly-property
Aug 27, 2019
Merged

Storage: Make 'Blob.bucket' a readonly property.#9113
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:9107-storage-blob-bucket-readonly-property

Conversation

@tseaver

@tseavertseaver commented Aug 27, 2019

Copy link
Copy Markdown
Contributor

Closes#9107.

@tseavertseaver added the api: storage Issues related to the Cloud Storage API. label Aug 27, 2019
@tseaver
tseaver requested a review from tswastAugust 27, 2019 17:40
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2019
frankyn
frankyn reviewed Aug 27, 2019
View reviewed changes
Comment threadstorage/google/cloud/storage/blob.py
tswast
tswast reviewed Aug 27, 2019
View reviewed changes
Comment threadstorage/google/cloud/storage/blob.py
Comment threadstorage/google/cloud/storage/blob.py
def bucket(self):
"""Bucket which contains the object.

:rtype: :class:`~google.cloud.storage.bucket.Bucket`

@tswasttswastAug 27, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Google-style docstrings on new methods.

@tseavertseaverAug 27, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems cleaner to make that a task to convert whole modules.

@crwilcoxcrwilcoxAug 27, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy if it matches the file in which it is added. Agree that we likely have a backlog task to do this though.

@tseaver

tseaver commented Aug 27, 2019

Copy link
Copy Markdown
ContributorAuthor

Unit test failures due to yesterday's google-resumable-media release: merge after #9119 is merged.

crwilcox
crwilcox approved these changes Aug 27, 2019
View reviewed changes
Comment threadstorage/google/cloud/storage/blob.py
def bucket(self):
"""Bucket which contains the object.

:rtype: :class:`~google.cloud.storage.bucket.Bucket`

@crwilcoxcrwilcoxAug 27, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy if it matches the file in which it is added. Agree that we likely have a backlog task to do this though.

@tseaver
tseaver merged commit 9289c52 into googleapis:masterAug 27, 2019
@tseaver
tseaver deleted the 9107-storage-blob-bucket-readonly-property branch August 27, 2019 22:32
HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
@tseaver
Make 'Blob.bucket' a readonly property. (googleapis#9113)
cab9af3
Closesgoogleapis#9107.
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@tseaver@emar-kar
Make 'Blob.bucket' a readonly property. (googleapis#9113)
daf830b
Closesgoogleapis#9107.
parthea pushed a commit that referenced this pull request Mar 9, 2026
@tseaver
Make 'Blob.bucket' a readonly property. (#9113)
5d778fb
Closes#9107.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast approved these changes
+2 more reviewers
@frankynfrankynfrankyn left review comments
@crwilcoxcrwilcoxcrwilcox approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Storage: Document public bucket property

5 participants

@tseaver@tswast@crwilcox@frankyn@googlebot