Skip to content

Storage: Expose id field for HMAC key - #9115

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tritone:master
Aug 28, 2019
Merged

Storage: Expose id field for HMAC key#9115
tseaver merged 2 commits into
googleapis:masterfrom
tritone:master

Conversation

@tritone

Copy link
Copy Markdown
Contributor

This is exposed in the client libraries for other languages and
is required for the samples to match.

This is exposed in the client libraries for other languages and
is required for the samples to match.
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2019
@tritonetritone changed the title Expose id field for HMAC keyStorage: Expose id field for HMAC keyAug 27, 2019
@tritone

Copy link
Copy Markdown
ContributorAuthor

This addresses issue #9114 .

@frankynfrankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2019
@tseaver

Copy link
Copy Markdown
Contributor

@tritone Unit tests were broken by yesterday's release of google-resumable-media-python. Can you please rebase your branch against the current master?

@tritone

Copy link
Copy Markdown
ContributorAuthor

@tseaver looks like that did the trick; thanks!

@tseaver
tseaver merged commit 68fbc07 into googleapis:masterAug 28, 2019
HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
parthea pushed a commit that referenced this pull request Mar 9, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tritone@tseaver@frankyn@googlebot@yoshi-kokoro