AutoML Tables: Enable users to pass in Pandas Dataframe when calling import_data() and batch_predict() from AutoML Tables client by TrucHLe · Pull Request #9116 · googleapis/google-cloud-python

TrucHLe · 2019-08-27T19:24:51Z

This PR:

Adds an optional param called pandas_dataframe to import_data() and batch_predict() of the Tables client.
Adds a Google Cloud Storage (GCS) client and invoke it from the Tables client whenever user wants to directly import a Pandas Dataframe.
Adds new unit & system test cases to cover the new use case.

lwander

LG! Just a few small comments

busunkim96

👋 I'm not completely sold on the added value of this wrapper. Perhaps this would be better suited for a sample than a library method? @sirtorry?

lwander · 2019-08-27T19:57:00Z

👋 I'm not completely sold on the added value of this wrapper.

We want to simplify the experience for datascientists in jupyter notebooks as much as possible. Typically they are doing feature engineering & data-processing on dataframes, and we don't want them to have to copy-paste a sample or learn to use another client library for simple things like this.

TrucHLe

First wave of comments resolved 😃 !

… statements

lwander

LGTM! 2 last comments from my end

…nd batch_predict() from AutoML Tables client (googleapis#9116)

…nd batch_predict() from AutoML Tables client (#9116)

TrucHLe requested a review from busunkim96 as a code owner August 27, 2019 19:24

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2019

lwander reviewed Aug 27, 2019
View reviewed changes

busunkim96 suggested changes Aug 27, 2019
View reviewed changes

Comment threadautoml/setup.py Outdated
Comment threadautoml/setup.py Outdated
Comment threadautoml/setup.py Outdated

lwander reviewed Aug 27, 2019
View reviewed changes

Comment threadautoml/google/cloud/automl_v1beta1/tables/gcs_client.py Outdated

TrucHLe added 9 commits August 27, 2019 15:59

Add GCS client
c4fa1e7

Reuse bucket for uploading dataframe
384657d

Remove unused google.auth dependency
e872279

Remove unused ctor param in GcsClient
a3c9454

Use GcsClient in TablesClient
4a6f39c

Add unit tests relating to GcsClient in TablesClient
1f4d4d9

Add system test for GcsClient
cfb9013

Auto lint the files
886d5d6

Update import statement so that Python 2.7 could link library with tests
4f9b107

TrucHLe force-pushed the trucle-b3 branch from d732182 to 4f9b107Compare August 27, 2019 20:03

TrucHLe added 3 commits August 27, 2019 17:54

Resolving comments on Aug 27, 2019
1a6bc2a

Remove unnecesary params in test
3222741

Auto lint some files
0487504

busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2019

TrucHLe added 2 commits August 27, 2019 18:07

Re-lint Tables unit test
0818996

Raise exception in GcsClient if Pandas is not imported
f6b2a9e

busunkim96 reviewed Aug 27, 2019
View reviewed changes

Comment threadautoml/google/cloud/automl_v1beta1/tables/gcs_client.py Outdated

TrucHLe added 2 commits August 27, 2019 18:25

Verify that google.cloud.storage is imported in GcsClient
6c2202e

Link dependencies to the tests so that Nox can run successfully
ed5f019

TrucHLe commented Aug 27, 2019
View reviewed changes

busunkim96 reviewed Aug 27, 2019
View reviewed changes

Comment threadautoml/google/cloud/automl_v1beta1/tables/gcs_client.py Outdated
Comment threadautoml/google/cloud/automl_v1beta1/tables/gcs_client.py Outdated
Comment threadautoml/google/cloud/automl_v1beta1/tables/gcs_client.py Outdated

sirtorry self-requested a review August 28, 2019 05:40

Init GcsClient only when Pandas Dataframe is passed + Reformat import…
9190485
… statements

tseaver added api: automl Issues related to the AutoML API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 28, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2019

lwander approved these changes Aug 28, 2019
View reviewed changes

Comment threadautoml/google/cloud/automl_v1beta1/tables/gcs_client.py
Comment threadautoml/google/cloud/automl_v1beta1/tables/tables_client.py

busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 28, 2019

busunkim96 approved these changes Aug 28, 2019
View reviewed changes

busunkim96 merged commit 0c7dd62 into googleapis:masterAug 28, 2019

HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
Enable users to pass in Pandas Dataframe when calling import_data() a…
36e7179
…nd batch_predict() from AutoML Tables client (googleapis#9116)

emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
Enable users to pass in Pandas Dataframe when calling import_data() a…
b9c0892
…nd batch_predict() from AutoML Tables client (googleapis#9116)

parthea pushed a commit that referenced this pull request Oct 21, 2023
Enable users to pass in Pandas Dataframe when calling import_data() a…
094674e
…nd batch_predict() from AutoML Tables client (#9116)

Uh oh!

Conversation

TrucHLe commented Aug 27, 2019

Uh oh!

lwander left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

busunkim96 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lwander commented Aug 27, 2019

Uh oh!

Uh oh!

Uh oh!

TrucHLe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lwander left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants