Uh oh!
There was an error while loading. Please reload this page.
feat(spanner): add client_options to constructor - #9151
Merged
Conversation
19 tasks
tseaver
approved these changes
Sep 3, 2019
tseaver
left a comment
Contributor
There was a problem hiding this comment.
LGTM. @busunkim96 can you confirm that the api_endpoint will be the same betweeen the three clients?
larkee
commented
Oct 18, 2019
Contributor
I can confirm that |
larkee
reviewed
Oct 21, 2019
Uh oh!
There was an error while loading. Please reload this page.
larkee
approved these changes
Oct 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #8475