feat(trace): add `client_options` to constructor by busunkim96 · Pull Request #9154 · googleapis/google-cloud-python

busunkim96 · 2019-08-30T23:09:42Z

Towards #8475

busunkim96 · 2019-10-22T20:22:33Z

The Cloud Build test is failing because the generated library has not been merged yet

busunkim96 added 3 commits August 30, 2019 16:04

Add client_options to constructor.
d97dcca

Blacken.
d7b1fad

Add more asserts.
eb9a4c4

busunkim96 added the api: cloudtrace Issues related to the Cloud Trace API. label Aug 30, 2019

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2019

busunkim96 mentioned this pull request Aug 30, 2019
Add client_options to constructors for manual clients. #8475
Closed
19 tasks

tseaver suggested changes Sep 3, 2019
View reviewed changes

Comment threadtrace/tests/unit/v2/test_client_v2.py Outdated

Blacken manually.
823bd00

busunkim96 changed the title ~~Trace: Add client_options to constructor.~~feat(trace): add client_options to constructorOct 22, 2019

tseaver approved these changes Oct 22, 2019
View reviewed changes

busunkim96 merged commit c6ecf19 into googleapis:masterOct 22, 2019

parthea pushed a commit that referenced this pull request Oct 22, 2023
feat(trace): addclient_optionsto constructor (#9154)
7cb1d20

Navigation Menu