Uh oh!
There was an error while loading. Please reload this page.
Removing datastore key query filter restriction. - #918
Merged
Conversation
Also checking in `Query` constructor that all the filters are valid. Fixesgoogleapis#917.
pcostell
commented
Jun 8, 2015
Contributor
Yes, key inequalities are allowed. |
tseaver
commented
Jun 9, 2015
Contributor
@pcostell does the API allow arbitrary rich comparisons on keys ( |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermes
commented
Jun 9, 2015
ContributorAuthor
tseaver
commented
Jun 9, 2015
Contributor
I see that @vinays uses |
pcostell
commented
Jun 9, 2015
Contributor
Yes I mean |
tseaver
commented
Jun 10, 2015
Contributor
@pcostell OK, thanks. For future reference, I found the docs for key filters which describe those semantics (but not as clearly as you did :). |
tseaver
commented
Jun 10, 2015
Contributor
@dhermes LGTM |
dhermes added a commit
that referenced
this pull request
Jun 10, 2015
Removing datastore key query filter restriction.
parthea pushed a commit
that referenced
this pull request
Mar 2, 2026
* feat: add cloud storage subscription fields PiperOrigin-RevId: 531202368 Source-Link: googleapis/googleapis@8a4cc94 Source-Link: googleapis/googleapis-gen@ec60ad7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWM2MGFkNzYzNTZkODhlOTlmYTQ4NDRmYmQ5MGZkY2NhNzI4ZjVjYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit
that referenced
this pull request
Mar 9, 2026
…ads, as a preview feature (#943) * checkpoint before design doc impl * checkpoint * more tests * code and tests for transfer manager complete * proactively close temp files when finished reading * respond to comments; destroy tmp files as they are consumed * Add system tests, docstrings, address feedback * Respond to review comments * verify md5 hash of downloaded file in test * lint * default empty strings for root arguments * fix bug with blob constructor * add warning about files not being deleted if their downloads fail * docs: Add samples to multithread branch (#918) * add samples, tests pending * add snippet tests * snippet and snippets_test.py linting * snippets; recursive directory creation; rename some params * Add directory upload snippet * fix: remove chunked downloads; change max_workers to threads * update snippets to add thread info * fix snippets test issue due to change in dependency * snippet nomenclature * fix samples for real this time
parthea pushed a commit
that referenced
this pull request
Mar 9, 2026
* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also checking in
Queryconstructor that all the filters are valid.Fixes#917.
@pcostell Can you verify that key inequality filters work? (The docs clearly state they do, just want to be careful.) This has been in the codebase longer than I've been working on the project, so maybe it was introduced before inequality filters were allowed?