Skip to content

BigQuery: Revert "Disable failing snippets test" - #9220

Merged
plamut merged 1 commit into
masterfrom
revert-9156-disable-failing-test
Sep 12, 2019
Merged

BigQuery: Revert "Disable failing snippets test"#9220
plamut merged 1 commit into
masterfrom
revert-9156-disable-failing-test

Conversation

@tswast

Copy link
Copy Markdown
Contributor

Reverts #9156

Per internal issue 140294699:

The bug affects table copy non-cmek into CMEK for tables created a long time ago. Does not affect new tables.

The engineering team has applied a fix for the problematic table bigquery-public-data:samples.shakespeare, so the test in question should now pass.

@tswast
tswast requested a review from a teamSeptember 12, 2019 16:06
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2019
@tswast
tswast requested a review from plamutSeptember 12, 2019 16:06
@tswasttswast added api: bigquery Issues related to the BigQuery API. type: process A process-related concern. May include testing, release, or the like. labels Sep 12, 2019

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🎉

@plamut
plamut merged commit 1a2311a into masterSep 12, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@tseaver
tseaver deleted the revert-9156-disable-failing-test branch August 24, 2021 16:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.type: processA process-related concern. May include testing, release, or the like.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast@plamut@googlebot