Skip to content

Adding namespace to dataset class. - #934

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:add-name-space-to-dataset
Jun 23, 2015
Merged

Adding namespace to dataset class.#934
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:add-name-space-to-dataset

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

This does not add support for namespace in _implicit_environ.

Related to #902.


As a result of #861 we will likely be removing _implicit_environ which makes this the actual resolution of #902.

/cc @jonparrott

This does not add support for namespace in `_implicit_environ`.
Related to googleapis#902.
@dhermesdhermes added the api: datastore Issues related to the Datastore API. label Jun 22, 2015
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2015
@dhermes

Copy link
Copy Markdown
ContributorAuthor

FWIW I checked where namespace is used in the .proto API. It is only used in PartitionId (along with dataset_id) and the PartitionId message type is only used in Key and RunQueryRequest.

Accordingly, the only places we support namespace is:

  • Connection.run_query(dataset_id, query_pb, namespace=...)
  • Key(..., namespace=...)
  • Query(..., namespace=...)

@theacodes

Copy link
Copy Markdown
Contributor

Cool, as long as it's an option on the client class when that happens I'm satisfied.

@tseaver

Copy link
Copy Markdown
Contributor

LGTM. I plan to rename datastore.dataset.Dataset -> datastore.client.Client after this merges.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

OK SGTM

dhermes added a commit that referenced this pull request Jun 23, 2015
@dhermes
dhermes merged commit 88f7c83 into googleapis:masterJun 23, 2015
@dhermes
dhermes deleted the add-name-space-to-dataset branch June 23, 2015 20:18
@dhermesdhermes mentioned this pull request Jul 10, 2015
parthea pushed a commit that referenced this pull request Nov 22, 2025
* chore(deps): update all dependencies
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 2, 2026
* chore(deps): update all dependencies
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
* fix: guard imports against unsupported pyarrow versions
* add unit tests
* fix pytype
* second try at fixing pytype
parthea pushed a commit that referenced this pull request Mar 6, 2026
parthea pushed a commit that referenced this pull request Mar 9, 2026
* fix: rst retry for txn
* rst changes and tests
* fix
* rst stream comment changes
* lint
* lint
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@theacodes@tseaver@googlebot