Uh oh!
There was an error while loading. Please reload this page.
doc(bigquery): add table create sample using integer range partitioning - #9478
Merged
Merged
Conversation
This code sample doubles as a system test for integer range partitioning features.
tswastforce-pushed
the
bq-range-partitioning-samples
branch
from
October 18, 2019 16:47
846b60c to
e1f6921Comparetswast
marked this pull request as ready for review
October 18, 2019 16:47
plamut
reviewed
Oct 22, 2019
plamut
left a comment
Contributor
There was a problem hiding this comment.
Looks good, please just blacken the changes (the lint check fails).
I noticed that table range partitioning info is not presented anywhere in the GCP control panel, but that's not a client library issue.
plamut
reviewed
Oct 25, 2019
plamut
left a comment
Contributor
There was a problem hiding this comment.
As discussed offline - even if not necessary, it is a good idea to include the sample in the Sphinx docs, too.
plamut
approved these changes
Oct 28, 2019
Contributor
@shollyman Is there anything that you might want to add here before merging? Thanks! Update: Seems like no, merging then. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code sample doubles as a system test for integer range partitioning features. Follow-up to #9477