Skip to content

feat(bigtable): add 'client_options' / 'admin_client_options' to Client - #9517

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:8475-bigtable-add-client_options-support
Oct 24, 2019
Merged

feat(bigtable): add 'client_options' / 'admin_client_options' to Client#9517
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:8475-bigtable-add-client_options-support

Conversation

@tseaver

@tseavertseaver commented Oct 22, 2019

Copy link
Copy Markdown
Contributor

Toward #8475.

Supersedes #9289.

@tseavertseaver added api: bigtable Issues related to the Bigtable API. api: bigtableadmin Issues related to the Cloud Bigtable Admin API API. labels Oct 22, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2019
@busunkim96busunkim96 mentioned this pull request Oct 22, 2019
Closed
19 tasks
@tseavertseaver changed the title feat(bigtable): add 'client_info' / 'admin_client_info' to Client.feat(bigtable): add 'client_info' / 'admin_client_info' to ClientOct 22, 2019
@tseaver

tseaver commented Oct 22, 2019

Copy link
Copy Markdown
ContributorAuthor

@busunkim96 This looks to be the last open PR to complete #8475.

@busunkim96busunkim96 changed the title feat(bigtable): add 'client_info' / 'admin_client_info' to Clientfeat(bigtable): add 'client_options' / 'admin_client_options' to ClientOct 22, 2019
busunkim96
busunkim96 approved these changes Oct 22, 2019
View reviewed changes

@busunkim96busunkim96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

Comment threadbigtable/google/cloud/bigtable/client.py Outdated
Comment threadbigtable/google/cloud/bigtable/client.py Outdated
Comment threadbigtable/google/cloud/bigtable/client.py Outdated
@tseaver@busunkim96
Apply suggestions from code review
cde9ee9
Co-Authored-By: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2019
@tseaver

tseaver commented Oct 24, 2019

Copy link
Copy Markdown
ContributorAuthor

Flaky systest reported in #9535.

@tseaver
tseaver merged commit 2beaa95 into googleapis:masterOct 24, 2019
@tseaver
tseaver deleted the 8475-bigtable-add-client_options-support branch October 24, 2019 18:33
parthea pushed a commit that referenced this pull request Nov 22, 2025
@tseaver
feat(bigtable): add 'client_options' / 'admin_client_options' to Clie…
e104354
…nt (#9517)
Toward #8475.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcoxcrwilcoxAwaiting requested review from crwilcox
@frankynfrankynAwaiting requested review from frankyn
1 more reviewer
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtableIssues related to the Bigtable API.api: bigtableadminIssues related to the Cloud Bigtable Admin API API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@busunkim96@googlebot@yoshi-kokoro