Skip to content

feat(storage): add 'ARCHIVE' storage class - #9533

Merged
crwilcox merged 5 commits into
googleapis:masterfrom
tseaver:9532-storage-add-archive-storage-class
Jan 2, 2020
Merged

feat(storage): add 'ARCHIVE' storage class#9533
crwilcox merged 5 commits into
googleapis:masterfrom
tseaver:9532-storage-add-archive-storage-class

Conversation

@tseaver

@tseavertseaver commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

Closes#9532.

@tseavertseaver added the api: storage Issues related to the Cloud Storage API. label Oct 24, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2019
@frankyn
frankyn requested a review from tritoneOctober 24, 2019 17:44
tritone
tritone reviewed Oct 25, 2019
View reviewed changes

@tritonetritone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise looks good to me pending approval from the language owner. Let's also wait to merge this until the feature is no longer behind a flag (will be a couple weeks).

Comment threadstorage/google/cloud/storage/constants.py Outdated
@tseavertseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 25, 2019
@tseaver

tseaver commented Oct 25, 2019

Copy link
Copy Markdown
ContributorAuthor

@tritone, @frankyn, @crwilcox Please approve when the feature is released on the back end.

@tseavertseaver added the status: blocked Resolving the issue is dependent on other work. label Oct 25, 2019
tritone
tritone approved these changes Dec 27, 2019
View reviewed changes

@tritonetritone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: we're now good to merge this with a plan to release the changes between 1/2 and 1/8 (once the release freeze has ended). Let me know if there's any issue with this timeline!

@tritone

tritone commented Dec 27, 2019

Copy link
Copy Markdown
Contributor

Update: we're now good to merge this with a plan to release the changes between 1/2 and 1/8 (once the release freeze has ended). Let me know if there's any issue with this timeline!

... also, it looks like we still need approval from a repo owner (@frankyn or @crwilcox ) as well as resolution of the Kokoro failure for Cloud Build (perhaps this just requires a rebase/rerun?).

@crwilcoxcrwilcox added kokoro:run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Jan 2, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 2, 2020
@crwilcox

crwilcox commented Jan 2, 2020

Copy link
Copy Markdown
Contributor

CI is looking good (ignore cloud build failure). Merging.

@crwilcox
crwilcox merged commit ac544b1 into googleapis:masterJan 2, 2020
This was referenced Jan 29, 2020
Merged
Merged
Closed
Closed
parthea pushed a commit that referenced this pull request Mar 9, 2026
@tseaver@crwilcox
feat(storage): add 'ARCHIVE' storage class (#9533)
2eb3af0
* feat(storage): add 'ARCHIVE' storage class
Closes#9532.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frankynfrankynAwaiting requested review from frankyn
2 more reviewers
@crwilcoxcrwilcoxcrwilcox approved these changes
@tritonetritonetritone approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Storage: Add support for Archive storage class

5 participants

@tseaver@tritone@crwilcox@googlebot@yoshi-kokoro