Skip to content

doc(bigquery): add code sample for scripting - #9537

Merged
tswast merged 3 commits into
googleapis:masterfrom
tswast:stackoverflow-58494128-procedure
Oct 28, 2019
Merged

doc(bigquery): add code sample for scripting#9537
tswast merged 3 commits into
googleapis:masterfrom
tswast:stackoverflow-58494128-procedure

Conversation

@tswast

Copy link
Copy Markdown
Contributor

This code sample initiates a scripting job and then demonstrates how to
fetch the results and the child jobs.

Removes system test for scripting, as it's redundant with the code
sample.

This code sample initiates a scripting job and then demonstrates how to
fetch the results and the child jobs.
Removes system test for scripting, as it's redundant with the code
sample.
@tswast
tswast requested review from a team, plamut and shollymanOctober 24, 2019 20:40
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2019
Comment threadbigquery/samples/query_script.py

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the remark @tseaver gave.

(disclaimer: I wrote the original system test that this sample is based on)

@tswast
tswast requested review from plamut and tseaverOctober 25, 2019 22:47

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@tswast
tswast merged commit 8e7e89c into googleapis:masterOct 28, 2019
@tswast
tswast deleted the stackoverflow-58494128-procedure branch October 28, 2019 17:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tswast@tseaver@plamut@googlebot