Skip to content

Move implicit majyk inside 'Client.__init__'. - #956

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:944-client_ctor_defaults
Jul 2, 2015
Merged

Move implicit majyk inside 'Client.__init__'.#956
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:944-client_ctor_defaults

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

See #944.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2015
@tseavertseaver mentioned this pull request Jul 1, 2015
8 tasks
@tseavertseaver added the api: datastore Issues related to the Datastore API. label Jul 1, 2015
Comment threadgcloud/datastore/client.py Outdated

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes

Copy link
Copy Markdown
Contributor

This seems pretty straightforward, thanks for making the change tiny and digestible :)

LGTM other than the comments I've already made.

tseaver added a commit that referenced this pull request Jul 2, 2015
Move implicit majyk inside 'Client.__init__'.
@tseaver
tseaver merged commit b840232 into googleapis:masterJul 2, 2015
@tseaver
tseaver deleted the 944-client_ctor_defaults branch July 2, 2015 15:51
@dhermesdhermes mentioned this pull request Jul 10, 2015
parthea pushed a commit that referenced this pull request Nov 24, 2025
Closes#955.
Co-authored-by: Bu Sun Kim <busunkim@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* feat: Add field information when raising validation errors.
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* fix: Fix string formatting error
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 25, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
* Make code changes in _default
* Add unit tests.
* Fix docstring.
Co-authored-by: arithmetic1728 <58957152+arithmetic1728@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
* refactor: extract common logic to TableBase class
* Adress pytype's missing attribute false warning
* Mark TableBase class as private
* Simplify TableReference.to_api_repr() logic
* Avoid get/set subproperty helper gotcha
* Test _TableBase class directly
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@dhermes@jgeewax@googlebot