Skip to content

fix(monitoring): make VPCSC env comparison case-insensitive - #9564

Merged
tseaver merged 5 commits into
googleapis:masterfrom
steinwaywhw:patch-3
Nov 6, 2019
Merged

fix(monitoring): make VPCSC env comparison case-insensitive#9564
tseaver merged 5 commits into
googleapis:masterfrom
steinwaywhw:patch-3

Conversation

@steinwaywhw

@steinwaywhwsteinwaywhw commented Oct 29, 2019

Copy link
Copy Markdown
Contributor

The actual environment variable value may be True, instead of true. So just make it case insensitive.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2019
@tseavertseaver changed the title Make VPCSC env comparison case-insensitive.fix(monitoring): make VPCSC env comparison case-insensitiveOct 29, 2019
tseaver
tseaver suggested changes Oct 29, 2019
View reviewed changes
Comment threadmonitoring/noxfile.py Outdated
Comment threadmonitoring/noxfile.py Outdated
@tseavertseaver mentioned this pull request Oct 29, 2019
Closed
2 tasks
@steinwaywhw@tseaver
Update monitoring/noxfile.py
cee06dc
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
@googlebot

googlebot commented Oct 31, 2019

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebotgooglebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 31, 2019
@steinwaywhw@tseaver
Update monitoring/noxfile.py
649a9b8
Co-Authored-By: Tres Seaver <tseaver@palladion.com>
@steinwaywhw

steinwaywhw commented Oct 31, 2019

Copy link
Copy Markdown
ContributorAuthor

@googlebot I fixed it.

@steinwaywhw

steinwaywhw commented Nov 4, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Hi @tseaver, please sign CLA using your personal email. See link above, or equivalently this one

@tseaver

tseaver commented Nov 5, 2019

Copy link
Copy Markdown
Contributor

@googlebot I consent.

@tseaver

tseaver commented Nov 5, 2019

Copy link
Copy Markdown
Contributor

@steinwaywhw I made those edits through the web: the e-mail associated with them (tseaver@palladion.com) is my normal one.

@googlebot

googlebot commented Nov 6, 2019

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebotgooglebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 6, 2019
steinwaywhw
steinwaywhw commented Nov 6, 2019
View reviewed changes

@steinwaywhwsteinwaywhw left a comment •
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark suggested edits as resolved.

@tseaver
tseaver merged commit 7a3a74d into googleapis:masterNov 6, 2019
@yoshi-automationyoshi-automation mentioned this pull request Jan 29, 2020
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
@steinwaywhw@tseaver
fix(monitoring): make VPCSC env comparison case-insensitive (#9564)
f4af0d1
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busunkim96busunkim96Awaiting requested review from busunkim96
1 more reviewer
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steinwaywhw@googlebot@tseaver