Skip to content

docs(bigquery): document how to achieve higher write limit and add tests - #9574

Merged
plamut merged 4 commits into
googleapis:masterfrom
plamut:iss-9539
Nov 1, 2019
Merged

docs(bigquery): document how to achieve higher write limit and add tests#9574
plamut merged 4 commits into
googleapis:masterfrom
plamut:iss-9539

Conversation

@plamut

@plamutplamut commented Oct 31, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#9539.

This PR documents how to achieve the higher write limit on streaming inserts, and extends unit tests to cover that case (i.e. no row insert IDs).

How to test

As mentioned in the last issue comment - check that the new code sample and the docs are indeed valid, and that new tests are sound

@plamutplamut added api: bigquery Issues related to the BigQuery API. type: docs Improvement to the documentation for an API. labels Oct 31, 2019
@plamut
plamut requested a review from a teamOctober 31, 2019 10:33
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2019
tseaver
tseaver suggested changes Oct 31, 2019
View reviewed changes
Comment threadbigquery/tests/unit/test_client.py Outdated
Comment threadbigquery/tests/unit/test_client.py Outdated
Comment threadbigquery/tests/unit/test_client.py Outdated
@plamut

plamut commented Nov 1, 2019

Copy link
Copy Markdown
ContributorAuthor

Renamed the methods along with the files as well for consistency.

@plamut
plamut requested a review from tseaverNovember 1, 2019 08:55
@plamut
plamut merged commit 3e8fbae into googleapis:masterNov 1, 2019
@plamut
plamut deleted the iss-9539 branch November 1, 2019 21:25
@yoshi-automationyoshi-automation mentioned this pull request Jan 29, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast approved these changes
+1 more reviewer
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.type: docsImprovement to the documentation for an API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: provide option to omit 'insertId' for 'insert_rows' and 'insert_rows_json'.

4 participants

@plamut@tseaver@tswast@googlebot