Skip to content

feat(spanner): add instance replica info; annotate protos, update docstrings (via synth) - #9577

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:9575-spanner-manual-synth
Nov 12, 2019
Merged

feat(spanner): add instance replica info; annotate protos, update docstrings (via synth)#9577
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:9575-spanner-manual-synth

Conversation

@tseaver

@tseavertseaver commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

Closes#9575.

@tseavertseaver added api: spanner Issues related to the Spanner API. codegen labels Oct 31, 2019
@tseaver
tseaver requested a review from frankyn as a code ownerOctober 31, 2019 15:12
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2019
@tseaver

tseaver commented Oct 31, 2019

Copy link
Copy Markdown
ContributorAuthor

Systest flakes due to #9534 (fix pending in #9579).

@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2019
@tseaver

tseaver commented Nov 5, 2019

Copy link
Copy Markdown
ContributorAuthor

@frankyn, @crwilcox, @busunkim96 PTAL

@tseaver

tseaver commented Nov 11, 2019

Copy link
Copy Markdown
ContributorAuthor

@crwilcox, @busunkim96 PTAL

busunkim96
busunkim96 approved these changes Nov 11, 2019
View reviewed changes

@busunkim96busunkim96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the caveat that I'm not familiar with the spanner code.

Daniel Azuma put out a warning in the Yoshi chatroom after reviewing the Ruby PR, but it doesn't seem to be an issue here?

We noticed that the latest spanner update introduced a breaking change at least in Ruby and PHP (some fields changed from required to optional, and as a result moved from positional to keyword arguments). Python and Node, you might want to check if that happened to you also.

@tseaver

tseaver commented Nov 11, 2019

Copy link
Copy Markdown
ContributorAuthor

@busunkim96 I don't see anything in our generated clients (instance admin, database admin, data) which includes such breaking changes.

@dazuma Were there specific APIs whose wrappers introduced such changes for Ruby / PHP?

@tseaver
tseaver merged commit d17f295 into googleapis:masterNov 12, 2019
@tseaver
tseaver deleted the 9575-spanner-manual-synth branch November 12, 2019 01:53
@yoshi-automationyoshi-automation mentioned this pull request Jan 29, 2020
Merged
parthea pushed a commit that referenced this pull request Mar 9, 2026
@tseaver
feat(spanner): add instance replica info; annotate protos, update doc…
8086f2e
…strings (via synth) (#9577)
Closes#9575.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcoxcrwilcoxAwaiting requested review from crwilcox
@frankynfrankynAwaiting requested review from frankyn
1 more reviewer
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spannerIssues related to the Spanner API.cla: yesThis human has signed the Contributor License Agreement.codegen

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@busunkim96@googlebot@yoshi-kokoro