Skip to content

tests(asset): normalize VPCSC config detection - #9582

Closed
tseaver wants to merge 4 commits into
googleapis:masterfrom
tseaver:9580-asset-normalize-vpcsc
Closed

tests(asset): normalize VPCSC config detection#9582
tseaver wants to merge 4 commits into
googleapis:masterfrom
tseaver:9580-asset-normalize-vpcsc

Conversation

@tseaver

@tseavertseaver commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

Uses #9581 as a base.

Toward #9580

@tseavertseaver added testing api: cloudasset Issues related to the Cloud Asset Inventory API. labels Oct 31, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2019
@tseaver

tseaver commented Nov 5, 2019

Copy link
Copy Markdown
ContributorAuthor

This PR is premature, because the use of the GOOGLE_CLOUD_TESTS_IN_VPCSC envvar in the asset system tests is non-standard: it defaults the variable to True, which is against the spec in this doc.

@tseavertseaver closed this Nov 5, 2019
@tseaver
tseaver deleted the 9580-asset-normalize-vpcsc branch November 5, 2019 19:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcoxcrwilcoxAwaiting requested review from crwilcox
@busunkim96busunkim96Awaiting requested review from busunkim96

Assignees

No one assigned

Labels

api: cloudassetIssues related to the Cloud Asset Inventory API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tseaver@googlebot