Skip to content

feat(datacatalog): add sample to create an entry group - #9584

Merged
tswast merged 2 commits into
googleapis:masterfrom
ricardolsmendes:add-create-entry-group-sample
Nov 1, 2019
Merged

feat(datacatalog): add sample to create an entry group#9584
tswast merged 2 commits into
googleapis:masterfrom
ricardolsmendes:add-create-entry-group-sample

Conversation

@ricardolsmendes

@ricardolsmendesricardolsmendes commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

Fixes#9583

@ricardolsmendes
ricardolsmendes requested a review from a teamOctober 31, 2019 21:48
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2019
@ricardolsmendesricardolsmendes changed the title Add sample to create an entry group in Data CatalogData Catalog: add sample to create an entry groupOct 31, 2019
@ricardolsmendesricardolsmendes changed the title Data Catalog: add sample to create an entry groupfeat(datacatalog): add sample to create an entry groupNov 1, 2019
@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
tswast
tswast requested changes Nov 1, 2019
View reviewed changes
Comment threaddatacatalog/noxfile.py Outdated
Comment threaddatacatalog/samples/tests/conftest.py Outdated
@tseavertseaver added the api: datacatalog Issues related to the Data Catalog API. label Nov 1, 2019
@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
@tswast

tswast commented Nov 1, 2019

Copy link
Copy Markdown
Contributor

Test failure: Google Cloud Data Catalog API has not been used in project 1065521786570 before or it is disabled. I'll try to enable it and re-run the tests.

@tswasttswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
@tswast
tswast merged commit 5571911 into googleapis:masterNov 1, 2019
@ricardolsmendes
ricardolsmendes deleted the add-create-entry-group-sample branch November 2, 2019 22:22
@yoshi-automationyoshi-automation mentioned this pull request Jan 29, 2020
Merged
parthea pushed a commit that referenced this pull request Jun 4, 2023
@ricardolsmendes@tswast
feat(datacatalog): add sample to create an entry group (#9584)
a5e5344
* feat(datacatalog): add sample to create an entry group
Closes#9583
* feat(datacatalog): add sample to create an entry group
Fix pytest fixtures and synth.py.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast approved these changes
+1 more reviewer
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datacatalogIssues related to the Data Catalog API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Data Catalog: add sample for creating an entry group

5 participants

@ricardolsmendes@tswast@tseaver@googlebot@yoshi-kokoro