Skip to content

fix(pubsub): update batching and flow control parameters to be same as the other client libraries - #9597

Merged
plamut merged 3 commits into
googleapis:masterfrom
pradn:harmonize-default-parameters
Nov 11, 2019
Merged

fix(pubsub): update batching and flow control parameters to be same as the other client libraries#9597
plamut merged 3 commits into
googleapis:masterfrom
pradn:harmonize-default-parameters

Conversation

@pradn

@pradnpradn commented Nov 4, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Changes:

  • Max batch size is reduced from 10 MB to 1 MB
  • Max latency before a batch is sent is reduced from 50 ms to 10 ms
  • Max messages in a batch is reduced from 1000 messages to 100 messages
  • Max messages in flight is increased from 100 messages to 1000 messages
  • Max ack extension is reduced from 2 hours to 1 hour
  • Also fix tests

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2019
@pradnpradn changed the title Update batching and flow control parameters to be same as the other client librariesfix(pubsub): Update batching and flow control parameters to be same as the other client librariesNov 4, 2019
@hongalexhongalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2019
@pradnpradn changed the title fix(pubsub): Update batching and flow control parameters to be same as the other client librariesfix(pubsub): update batching and flow control parameters to be same as the other client librariesNov 4, 2019
@hongalex

hongalex commented Nov 4, 2019

Copy link
Copy Markdown
Member

@busunkim96 This PR is part of an effort to standardize our client library default settings. We're looking at two changes. One change increases how often we publish bundles of messages (which shouldn't be a breaking change).

The other has to do with flow control (how many messages we can hold and how long we hold onto messages before releasing them to be redelivered). I'm more worried about this change negatively affecting users who aren't setting their own defaults. What do you recommend here?

plamut
plamut reviewed Nov 5, 2019
View reviewed changes
Comment threadpubsub/tests/unit/pubsub_v1/subscriber/test_streaming_pull_manager.py Outdated
plamut
plamut approved these changes Nov 5, 2019
View reviewed changes

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good per se. I am not totally familiar with the defaults in other libraries, thus I'll leave that aspect to others to verify.

@plamutplamut added the api: pubsub Issues related to the Pub/Sub API. label Nov 7, 2019
This was referenced Nov 7, 2019
Closed
Merged
@plamut

plamut commented Nov 11, 2019

Copy link
Copy Markdown
Contributor

Merging to unblock a related PR. If it turns out that additional changes are needed, we can make them in a follow-up PR.

@plamut
plamut merged commit 6a46ac2 into googleapis:masterNov 11, 2019
@yoshi-automationyoshi-automation mentioned this pull request Jan 29, 2020
Merged
parthea pushed a commit that referenced this pull request Mar 2, 2026
@pradn@plamut
fix(pubsub): update batching and flow control parameters to be same a…
c5eba0f
…s the other client libraries (#9597)
* Update batching and flow control parameters to be same as the other client libraries.
* Fix tests
* Update test leaser param
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anguillanneufanguillanneufAwaiting requested review from anguillanneuf
@busunkim96busunkim96Awaiting requested review from busunkim96
1 more reviewer
@plamutplamutplamut approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pradn@hongalex@plamut@googlebot@yoshi-kokoro