Skip to content

feat(bigquery): add --destination_table parameter to bigquery magic - #9599

Merged
plamut merged 1 commit into
googleapis:masterfrom
vlasenkoalexey:master
Nov 6, 2019
Merged

feat(bigquery): add --destination_table parameter to bigquery magic#9599
plamut merged 1 commit into
googleapis:masterfrom
vlasenkoalexey:master

Conversation

@vlasenkoalexey

@vlasenkoalexeyvlasenkoalexey commented Nov 5, 2019

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Sample use and test here: https://colab.research.google.com/drive/1vd_5IperzwBdqnzIPKd8fWkGZg4TO1Bb (google access only)

Fixes#9598
@sshrdp FYI

@vlasenkoalexey
vlasenkoalexey requested a review from a teamNovember 5, 2019 01:37
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 5, 2019
@vlasenkoalexey

vlasenkoalexey commented Nov 5, 2019

Copy link
Copy Markdown
ContributorAuthor

@tswast could you take a look

plamut
plamut reviewed Nov 5, 2019
View reviewed changes

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and seems to work as expected. 👍

I only have a few minor house-keeping comments.

Comment threadbigquery/google/cloud/bigquery/magics.py Outdated
Comment threadbigquery/google/cloud/bigquery/magics.py Outdated
Comment threadbigquery/google/cloud/bigquery/magics.py Outdated
Comment threadbigquery/tests/unit/test_magics.py Outdated
@tseavertseaver changed the title added --destination_table parameter to bigquery magicfeat(bigquery): add --destination_table parameter to bigquery magicNov 5, 2019
vlasenkoalexey
vlasenkoalexey commented Nov 5, 2019
View reviewed changes

@vlasenkoalexeyvlasenkoalexey left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR

@plamutplamut added the api: bigquery Issues related to the BigQuery API. label Nov 5, 2019
plamut
plamut approved these changes Nov 5, 2019
View reviewed changes

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@vlasenkoalexey

vlasenkoalexey commented Nov 6, 2019

Copy link
Copy Markdown
ContributorAuthor

Is Kokoro - Cloud Build failure a real issue or just a glitch? It doesn't return any logs.

@tswast

tswast commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

Cloud Build client is currently broken, so this failure is expected.

@plamut

plamut commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

As @tswast said - the Cloud Build is currently broken, and the failure is unrelated to this PR.

@plamut
plamut merged commit 9405db9 into googleapis:masterNov 6, 2019
@yoshi-automationyoshi-automation mentioned this pull request Jan 29, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@plamutplamutplamut approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: Add destination_table to %%bigquery magic to allow materializing query results

4 participants

@vlasenkoalexey@tswast@plamut@googlebot