Uh oh!
There was an error while loading. Please reload this page.
fix(spanner): fix TransactionPingingPool throwing error ''NoneType' object is not callable' - #9609
Conversation
tseaver
left a comment
There was a problem hiding this comment.
Rather than tweak the hand-rolled _Transaction mock, let's take this as an opportunity to replace it with an "mock autospec" version, which will auttomatically keep the signatures correct.
larkee
commented
Nov 7, 2019
The mock autospec does not support static attributes which causes test_put_non_full_w_active_txn to fail because txn.committed is a NonCallableMagicMock, not None. I don't see an easy fix for that. Perhaps, it would be easier to go with the original change and have this refactor in a subsequent PR? |
tseaver
commented
Nov 7, 2019
@larkee Hmm, odd: I pasted in that change after making it locally, and got all the tests to pass. Nevertheless, we can update the |
larkee
commented
Nov 11, 2019
@tseaver PTAL |
…bject is not callable' (#9609)
TransactionPingingPool is throwing error ''NoneType' object is not callable' when trying to batch insert. This is the fix.