Skip to content

feat(bigquery): add support for hive partitioning options configuration - #9626

Merged
tswast merged 4 commits into
googleapis:masterfrom
plamut:iss-9610
Nov 19, 2019
Merged

feat(bigquery): add support for hive partitioning options configuration#9626
tswast merged 4 commits into
googleapis:masterfrom
plamut:iss-9610

Conversation

@plamut

@plamutplamut commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

Fixes#9610.

This PR adds support for configuring hive partitioning to LoadJobConfig and ExternalConfig classes.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamutplamut added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: bigquery Issues related to the BigQuery API. labels Nov 7, 2019
@plamut
plamut requested a review from a teamNovember 7, 2019 08:45
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2019
@plamutplamut changed the title feat(bigquery): add support hive partitioning options configurationfeat(bigquery): add support for hive partitioning options configurationNov 7, 2019
@plamut

plamut commented Nov 7, 2019

Copy link
Copy Markdown
ContributorAuthor

The internal server error that makes the undelete table snippet test fail does not seem to be related, happens on the master branch as well. We should re-run the test suite again in a few hours.

@plamutplamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2019
@plamutplamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
tswast
tswast reviewed Nov 12, 2019
View reviewed changes
Comment threadbigquery/google/cloud/bigquery/external_config.py Outdated
@plamut
plamut requested a review from tswastNovember 13, 2019 07:32
@plamutplamut mentioned this pull request Nov 18, 2019
Closed
tswast
tswast approved these changes Nov 19, 2019
View reviewed changes

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see a system test for this, too, but that's partially on me to make sure we have some public data we can use for that. I'll follow-up with a code sample for that once we have it.

@tswast
tswast merged commit 15d4bb6 into googleapis:masterNov 19, 2019
@plamut
plamut deleted the iss-9610 branch November 19, 2019 07:13
This was referenced Jan 29, 2020
Merged
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: Add support for configuring Hive partitioning options

4 participants

@plamut@tswast@googlebot@yoshi-kokoro